[ruby-core:110044] [Ruby master Bug#18784] `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
From:
"Dan0042 (Daniel DeLorme)" <noreply@...>
Date:
2022-09-23 12:55:31 UTC
List:
ruby-core #110044
SXNzdWUgIzE4Nzg0IGhhcyBiZWVuIHVwZGF0ZWQgYnkgRGFuMDA0MiAoRGFuaWVsIERlTG9ybWUp Lg0KDQoNCkhlcmUncyBhIHVzZSBjYXNlIGZvciBhIGBybV9mYCB0aGF0IG9ubHkgaWdub3JlcyBF Tk9FTlQgZXJyb3JzLiBCZWZvcmUgcHJvY2Vzc2luZywgeW91IHdhbnQgdG8gZGVsZXRlIGEgY2Fj aGUgZmlsZSAodGhhdCBtYXkgb3IgbWF5IG5vdCBleGlzdCkgc28gdGhlIHByb2Nlc3NpbmcgcmVn ZW5lcmF0ZXMgaXQuIEJ1dCBpZiB0aGUgZmlsZSBleGlzdHMsIGl0ICoqbXVzdCoqIGJlIGRlbGV0 ZWQsIG90aGVyd2lzZSB0aGUgcHJvY2Vzc2luZyB3b3VsZCB1c2UgdGhlIGNhY2hlIGZpbGUgaW5z dGVhZCBvZiByZWdlbmVyYXRlIGl0Lg0KDQpJIHRoaW5rIGl0IHdvdWxkIGJlIHVzZWZ1bCB0byBo YXZlIHRoYXQgbWV0aG9kIGluIEZpbGVVdGlscyAoYW5kIFBhdGhuYW1lKSBpbnN0ZWFkIG9mIGBG aWxlLmRlbGV0ZShwYXRoKSBpZiBGaWxlLmV4aXN0PyhwYXRoKWAuIEEgc2ltcGxlIG5hbWUgbGlr ZSBgRmlsZVV0aWxzLnJtIWAgd291bGQgZW5jb3VyYWdlIHRoaXMgYXMgdGhlICJjb3JyZWN0IiBt ZXRob2QgdG8gdXNlIHdoaWxlIHByZXNlcnZpbmcgYmFja3dhcmQgY29tcGF0aWJpbGl0eSBmb3Ig YHJtX2ZgLg0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpCdWcg IzE4Nzg0OiBgRmlsZVV0aWxzLnJtX2ZgIGFuZCBgRmlsZVV0aWxzLnJtX3JmYCBzaG91bGQgbm90 IG1hc2sgZXhjZXB0aW9ucw0KaHR0cHM6Ly9idWdzLnJ1YnktbGFuZy5vcmcvaXNzdWVzLzE4Nzg0 I2NoYW5nZS05OTI5NA0KDQoqIEF1dGhvcjogZGVpdmlkIChEYXZpZCBSb2Ryw61ndWV6KQ0KKiBT dGF0dXM6IE9wZW4NCiogUHJpb3JpdHk6IE5vcm1hbA0KKiBBc3NpZ25lZTogbWFtZSAoWXVzdWtl IEVuZG9oKQ0KKiBydWJ5IC12OiBydWJ5IDMuMS4ycDIwICgyMDIyLTA0LTEyIHJldmlzaW9uIDQ0 OTFiYjc0MGEpIFthcm02NC1kYXJ3aW4yMV0NCiogQmFja3BvcnQ6IDIuNzogVU5LTk9XTiwgMy4w OiBVTktOT1dOLCAzLjE6IFVOS05PV04NCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0NCkluIHJlY2VudCB0aW1lcywgSSd2ZSBiZWVuIGhhdmluZyBpc3N1ZXMgd2l0aCB0 aGVzZSBtZXRob2RzIGJlY2F1c2UgdGhleSBkb24ndCBsZXQgeW91IGtub3cgd2hlbiBzb21lIGlz c3VlIGhhcHBlbmVkIHdoaWxlIHRyeWluZyB0byByZW1vdmUgdGhlIGdpdmVuIGZvbGRlcnMvZmls ZXMuDQoNCklNTyBtb3N0IHVzZXJzIGV4cGVjdCBhbGwgcHJlLWV4aXN0aW5nIGZvbGRlcnMvZmls ZXMgdGhhdCBhcmUgcGFzc2VkIHRvIHRoZXNlIG1ldGhvZHMgdG8gYmUgYWN0dWFsbHkgcmVtb3Zl ZCBieSB0aGUgbWV0aG9kcy4gSW5zdGVhZCwgd2hlbiB0aGlzIGhhcHBlbnMsIGVycm9ycyBhcmUg c2lsZW50bHkgc3dhbGxvd2VkIGFuZCBub3JtYWxseSB0aGUgcmVzdWx0IGlzIHRoYXQgeW91IHdp bGwgZ2V0IHNvbWUgb3RoZXIgaXNzdWUgZnVydGhlciBkb3duIHRoZSByb2FkLCBtYWtpbmcgdGhl IHByb2JsZW0gaGFyZCB0byBkZWJ1Zy4NCg0KVGhlIGN1cnJlbnQgd29ya2Fyb3VuZCBJJ20gdXNp bmcgaXMgdG8gZG91YmxlIGNoZWNrIHdoZXRoZXIgdGhlIGZpbGVzIHN0aWxsIGV4aXN0IGFmdGVy IHRoZSBtZXRob2QsIGFuZCByYWlzZSBhIGN1c3RvbSBlcnJvciBpZiB0aGV5IGRvLCBidXQgSSBz dGlsbCBjYW4ndCBzZWUgdGhlIG9yaWdpbmFsIHByb2JsZW0sIHNvIGlzc3VlcyBhcmUgc2ltaWxh cmx5IGhhcmQgdG8gZGVidWcuDQoNClRoaXMgaXMgYWxzbyBhIGRldmlhdGlvbiBmcm9tIGhvdyBg cm0gLXJmYCBhbmQgYHJtIC1mYCB3b3JrLCBzaW5jZSB0aGVzZSB0b29scyBmaW5pc2ggd2l0aCBh IGZhaWx1cmUgZXhpdCBjb2RlIHdoZW4gdGhleSBmYWlsIHRvIHJlbW92ZSB0aGUgZ2l2ZW4gZmls ZXMuIEdpdmVuIHRoYXQgYGZpbGV1dGlsc2AgaXMgaW50ZW5kZWQgdG8gbWltaWMgc2hlbGwgZnVu Y3Rpb25hbGl0eSwgSSB0aGluayB0aGlzIGlzIGp1c3QgYSBidWcuDQoNCkkgdGhpbmsgdGhlIGlu dGVudGlvbiBvZiB0aGUgYGZvcmNlYCBmbGFnIGhlcmUgaXMgdG86DQoqIERvbid0IHByb21wdCBm b3IgY29uZmlybWF0aW9uLg0KKiBJZ25vcmUgZ2l2ZW4gYXJndW1lbnRzIHRoYXQgYXJlIG5vdCBm aWxlcyB0aGF0IGFscmVhZHkgZXhpc3QuDQoNCkJ1dCBhbnkgaXNzdWUgb3RoZXIgdGhhbiB0aGF0 IHNob3VsZCBub3QgYmUgc3dhbGxvd2VkLCBhbmQgaW4gZ2VuZXJhbCBJIHRoaW5rIHRoZSBtZXRo b2Qgc2hvdWxkIHN1Y2NlZWQgaWYgYW5kIG9ubHkgaWYgdGhlIGdpdmVuIGxpc3Qgb2YgZmlsZSBu YW1lcyBkb2VzIG5vdCBleGlzdCBhZnRlciB0aGUgbWV0aG9kcyBhcmUgZG9uZS4NCg0KSSB0aGlu ayB0aGlzIGlzIGluIGxpbmUgd2l0aCB0aGUgZm9sbG93aW5nIG5vdGUgSSBnZXQgd2hlbiBJIHJ1 biBgbWFuIHJtYCwgYnV0IGFsc28gc3VnZ2VzdHMgdGhhdCB0aGlzIGlzIG5vdCB0aGUgc3RhbmRh cmQgYmVoYXZpb3Igb2YgImhpc3RvcmljYWwgaW1wbGVtZW50YXRpb25zIg0KDQo+IENPTVBBVElC SUxJVFkNCj4NCj4gVGhlIHJtIHV0aWxpdHkgZGlmZmVycyBmcm9tIGhpc3RvcmljYWwgaW1wbGVt ZW50YXRpb25zIGluIHRoYXQgdGhlIC1mIG9wdGlvbiBvbmx5IG1hc2tzIGF0dGVtcHRzIHRvIHJl bW92ZSBub24tZXhpc3RlbnQgZmlsZXMgaW5zdGVhZCBvZiBtYXNraW5nIGEgbGFyZ2UgdmFyaWV0 eSBvZiBlcnJvcnMuDQoNCkkgaW1wbGVtZW50ZWQgdGhpcyBhdCBodHRwczovL2dpdGh1Yi5jb20v cnVieS9maWxldXRpbHMvcHVsbC81OCwgYnV0IHRyZWF0aW5nIHRoaXMgYXMgYSBidWcuIEkgY2Fu IGFsc28gaW1wbGVtZW50IGEgbW9yZSBjb25zZXJ2YXRpdmUgZm9yIGFwcHJvYWNoIGZvciB1c2Vy cyB0aGF0IG1pZ2h0IGJlIHVzaW5nIGBGaWxlVXRpbHMucm1fcmZgIG9yIGBGaWxlVXRpbHMucm1f ZmAgYnV0IGRvbid0IHJlYWxseSBjYXJlIGlmIHRoZSBmaWxlcyBhcmUgcmVtb3ZlZCBvciBub3Qu DQoNCkFsdGVybmF0aXZlIHByb3Bvc2FscyB3b3VsZCBiZSBgRmlsZVV0aWxzLnJtX3JmKGZvcmNl OiBzdHJpY3QpYCwgb3IgYEZpbGVVdGlscy5zdHJpY3Rfcm1fcmZgLCBidXQgdG8gYmUgaG9uZXN0 LCBpZiB0aGlzIGlzIGNvbnNpZGVyZWQgYSBicmVha2luZyBjaGFuZ2UsIEkgd291bGQgc2hpcCBp dCBhcyBhIG5ldyBtYWpvciB2ZXJzaW9uLCBhbmQgbGV0IHVzZXJzIHVwZGF0ZSB0aGVpciBjb2Rl IHRvIHN3YWxsb3cgZXJyb3JzIHRoZW1zZWx2ZXMgaWYgdGhleSBuZWVkIHRvLg0KDQpIYXBweSB0 byBoZWFyIGFueSBmZWVkYmFjayENCg0KDQoNCi0tIA0KaHR0cHM6Ly9idWdzLnJ1YnktbGFuZy5v cmcvDQoKVW5zdWJzY3JpYmU6IDxtYWlsdG86cnVieS1jb3JlLXJlcXVlc3RAcnVieS1sYW5nLm9y Zz9zdWJqZWN0PXVuc3Vic2NyaWJlPgo8aHR0cDovL2xpc3RzLnJ1YnktbGFuZy5vcmcvY2dpLWJp bi9tYWlsbWFuL29wdGlvbnMvcnVieS1jb3JlPgo=