[ruby-core:108128] [Ruby master Feature#18668] Merge `io-nonblock` gems into core

Issue #18668 has been updated by shyouhei (Shyouhei Urabe).


I don't think this gem deserves a room into core.  Are there any practical usages of it?  Note that `IO#read_nonblock` is an unrelated method (works with or without of this).

Also, are we going to add tons of trivial methods into core just because they are small?  I guess we need good reasons for each of them to exist.

----------------------------------------
Feature #18668: Merge `io-nonblock` gems into core
https://bugs.ruby-lang.org/issues/18668#change-97103

* Author: Eregon (Benoit Daloze)
* Status: Open
* Priority: Normal
----------------------------------------
The new io-nonblock gem defines just 3 methods on IO: (https://github.com/ruby/io-nonblock/blob/e20578b24405d225e6383d6c5ebfb7ffefac646b/ext/io/nonblock/nonblock.c#L137-L139)
* IO#nonblock?
* IO#nonblock=(nonblock)
* IO#nonblock(nonblock = true, &block)

I think these 3 methods should move to core, and the gem become a noop if these methods are already defined in core.
These methods are small and yet they access IO internals and their behavior is extremely unlikely to change.
Their behavior and names are well known and established.

The benefit of a gem seems nonexistent here (no point to version those 3 methods), while the cost is significant (have to support each Ruby implementation, while this code just makes more sense in each Ruby implementation's repo).

io/nonblock is useful to tell if an IO is in non-blocking mode and to set it upfront.
This is needed when using a Fiber scheduler but also other cases such as https://bugs.ruby-lang.org/issues/18630#note-9.

In fact `io/nonblock` is so small it's already core in TruffleRuby.
Many core IO methods even need to check/set whether an IO is nonblocking, so it's natural to just use the existing methods for that when such IO methods are written in Ruby.

No gem seems to depend on io-nonblock anyway, so it seems of no use to be a gem, and it should either be core or stdlib-not-a-gem:
https://github.com/ruby/io-nonblock/network/dependents
https://rubygems.org/gems/io-wait/reverse_dependencies

Proposal:

* Merge io-nonblock into io.c for Ruby 3.2
* Publish a new io-nonblock version that simply noops if the methods are already defined, or an empty gem (so the stdlib io/nonblock gets used).
* Add a lib/io/nonblock.rb stub for compatibility, with eventually a deprecation warning.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>