[ruby-core:107878] Re: Fwd: [ruby-cvs:91197] 8f59482f5d (master): add some tests for Unicode Version 14.0.0

It's simply the guard is incorrect, it needs to say ">= 3.1 and < 3.2", so
`ruby_version_is "3.1"..."3.2" do`,
not just `ruby_version_is "3.1" do` which means ">= 3.1" (so includes 3.2,
3.3, etc).
I thought it'd be pretty obvious from the previous guards, but apparently
not.

We might change the usages from `ruby_version_is "3.1" do` to
`ruby_version_is "3.1"... do` to make this clearer in the future.

On Sun, Mar 13, 2022 at 2:16 AM Martin J. D端rst <[e-mail]>
wrote:

> Hello Benoit, others,
>
> Some CI checks fail as below (see e.g.
> https://github.com/ruby/ruby/runs/5524900743?check_suite_focus=true)
> with a version mismatch.
> My understanding was that we are now on Ruby 3.2, so it's unclear why in
> these tests, Ruby thinks it's still Ruby 3.1. When I checked before
> submitting with `make check`, there were no such errors.
>
> Regards,   Martin.
>
>    1)
>    RbConfig::CONFIG['UNICODE_EMOJI_VERSION'] is 13.1 for Ruby 3.1 FAILED
>    Expected "14.0" == "13.1"
>    to be truthy but was false
>
> /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_emoji_version_spec.rb:25:in
>
> `block (3 levels) in <top (required)>'
>
> /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_emoji_version_spec.rb:4:in
>
> `<top (required)>'
>
>    2)
>    RbConfig::CONFIG['UNICODE_VERSION'] is 13.0.0 for Ruby 3.1 FAILED
>    Expected "14.0.0" == "13.0.0"
>    to be truthy but was false
>
> /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_version_spec.rb:25:in
>
> `block (3 levels) in <top (required)>'
>
> /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_version_spec.rb:4:in
>
> `<top (required)>'
>
>    Finished in 46.945332 seconds
>
>    3823 files, 30988 examples, 131590 expectations, 2 failures, 0
> errors, 0 tagged
>    make: *** [uncommon.mk:865: yes-test-spec] Error 1
>    Error: Process completed with exit code 2.
>
> On 2022-03-13 10:05, Martin J. D端rst wrote:
> > To everybody taking care of continuous integration:
> >
> > Please note that your CI may need new cached data files for Unicode
> > Version 14.0.0 / Emoji Version 14.0. These files do not get downloaded
> > in a usual compilation of Ruby to avoid lots of unneeded network traffic.
> >
> > Regards,   Martin.
> >
> >
> > -------- Forwarded Message --------
> > Subject: [ruby-cvs:91197] 8f59482f5d (master): add some tests for
> > Unicode Version 14.0.0
> > Date: Sun, 13 Mar 2022 09:41:37 +0900 (JST)
> > From: Martin D端rst <[e-mail]>
> > To: [e-mail]
> >
> > Martin D端rst    2022-03-12 21:33:51 +0900 (Sat, 12 Mar 2022)
> >
> >    New Revision: 8f59482f5d
> >
> >    https://github.com/ruby/ruby/commit/8f59482f5d
> >
> >    Log:
> >      add some tests for Unicode Version 14.0.0
> >
> >    Modified files:
> >      test/ruby/test_regexp.rb
> >      test/ruby/test_string.rb.
> >
> > Unsubscribe: <mailto:[e-mail]
> ?subject=unsubscribe>
> > <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
>
>

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>