From: Benoit Daloze Date: 2022-03-13T13:15:38+01:00 Subject: [ruby-core:107878] Re: Fwd: [ruby-cvs:91197] 8f59482f5d (master): add some tests for Unicode Version 14.0.0 --===============1457902065== Content-Type: multipart/alternative; boundary="000000000000b75d7c05da188789" --000000000000b75d7c05da188789 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It's simply the guard is incorrect, it needs to say ">=3D 3.1 and < 3.2", s= o `ruby_version_is "3.1"..."3.2" do`, not just `ruby_version_is "3.1" do` which means ">=3D 3.1" (so includes 3.2= , 3.3, etc). I thought it'd be pretty obvious from the previous guards, but apparently not. We might change the usages from `ruby_version_is "3.1" do` to `ruby_version_is "3.1"... do` to make this clearer in the future. On Sun, Mar 13, 2022 at 2:16 AM Martin J. D=C3=BCrst wrote: > Hello Benoit, others, > > Some CI checks fail as below (see e.g. > https://github.com/ruby/ruby/runs/5524900743?check_suite_focus=3Dtrue) > with a version mismatch. > My understanding was that we are now on Ruby 3.2, so it's unclear why in > these tests, Ruby thinks it's still Ruby 3.1. When I checked before > submitting with `make check`, there were no such errors. > > Regards, Martin. > > 1) > RbConfig::CONFIG['UNICODE_EMOJI_VERSION'] is 13.1 for Ruby 3.1 FAILED > Expected "14.0" =3D=3D "13.1" > to be truthy but was false > > /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_emoji_= version_spec.rb:25:in > > `block (3 levels) in ' > > /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_emoji_= version_spec.rb:4:in > > `' > > 2) > RbConfig::CONFIG['UNICODE_VERSION'] is 13.0.0 for Ruby 3.1 FAILED > Expected "14.0.0" =3D=3D "13.0.0" > to be truthy but was false > > /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_versio= n_spec.rb:25:in > > `block (3 levels) in ' > > /home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_versio= n_spec.rb:4:in > > `' > > Finished in 46.945332 seconds > > 3823 files, 30988 examples, 131590 expectations, 2 failures, 0 > errors, 0 tagged > make: *** [uncommon.mk:865: yes-test-spec] Error 1 > Error: Process completed with exit code 2. > > On 2022-03-13 10:05, Martin J. D=C3=BCrst wrote: > > To everybody taking care of continuous integration: > > > > Please note that your CI may need new cached data files for Unicode > > Version 14.0.0 / Emoji Version 14.0. These files do not get downloaded > > in a usual compilation of Ruby to avoid lots of unneeded network traffi= c. > > > > Regards, Martin. > > > > > > -------- Forwarded Message -------- > > Subject: [ruby-cvs:91197] 8f59482f5d (master): add some tests for > > Unicode Version 14.0.0 > > Date: Sun, 13 Mar 2022 09:41:37 +0900 (JST) > > From: Martin D=C3=BCrst > > To: ruby-cvs@ruby-lang.org > > > > Martin D=C3=BCrst 2022-03-12 21:33:51 +0900 (Sat, 12 Mar 2022) > > > > New Revision: 8f59482f5d > > > > https://github.com/ruby/ruby/commit/8f59482f5d > > > > Log: > > add some tests for Unicode Version 14.0.0 > > > > Modified files: > > test/ruby/test_regexp.rb > > test/ruby/test_string.rb. > > > > Unsubscribe: ?subject=3Dunsubscribe> > > > > --000000000000b75d7c05da188789 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It's simply the guard is incorrect, it needs to say &q= uot;>=3D=C2=A03.1 and < 3.2", so `ruby_version_is "3.1"= ;..."3.2" do`,
not just `ruby_version_is "3.1" do` w= hich means ">=3D 3.1" (so includes 3.2, 3.3, etc).
I thoug= ht it'd be pretty obvious from the previous guards,=C2=A0but apparently= not.

We might change the usages from `ruby_versio= n_is "3.1" do` to `ruby_version_is "3.1"... do` to make= this clearer in the future.

On Sun, Mar 13, 2022 at 2:16 AM Martin J.= D=C3=BCrst <duerst@it.aoyama.= ac.jp> wrote:
Hello Benoit, others,

Some CI checks fail as below (see e.g.
https://github.com/ruby/ruby/= runs/5524900743?check_suite_focus=3Dtrue)
with a version mismatch.
My understanding was that we are now on Ruby 3.2, so it's unclear why i= n
these tests, Ruby thinks it's still Ruby 3.1. When I checked before submitting with `make check`, there were no such errors.

Regards,=C2=A0 =C2=A0Martin.

=C2=A0 =C2=A01)
=C2=A0 =C2=A0RbConfig::CONFIG['UNICODE_EMOJI_VERSION'] is 13.1 for = Ruby 3.1 FAILED
=C2=A0 =C2=A0Expected "14.0" =3D=3D "13.1"
=C2=A0 =C2=A0to be truthy but was false

/home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_emoji_ve= rsion_spec.rb:25:in
`block (3 levels) in <top (required)>'

/home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_emoji_ve= rsion_spec.rb:4:in
`<top (required)>'

=C2=A0 =C2=A02)
=C2=A0 =C2=A0RbConfig::CONFIG['UNICODE_VERSION'] is 13.0.0 for Ruby= 3.1 FAILED
=C2=A0 =C2=A0Expected "14.0.0" =3D=3D "13.0.0"
=C2=A0 =C2=A0to be truthy but was false

/home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_version_= spec.rb:25:in
`block (3 levels) in <top (required)>'

/home/runner/work/ruby/ruby/src/spec/ruby/library/rbconfig/unicode_version_= spec.rb:4:in
`<top (required)>'

=C2=A0 =C2=A0Finished in 46.945332 seconds

=C2=A0 =C2=A03823 files, 30988 examples, 131590 expectations, 2 failures, 0=
errors, 0 tagged
=C2=A0 =C2=A0make: *** [uncommon.mk:865: yes-test-spec] Error 1
=C2=A0 =C2=A0Error: Process completed with exit code 2.

On 2022-03-13 10:05, Martin J. D=C3=BCrst wrote:
> To everybody taking=C2=A0care=C2=A0of continuous integration:
>
> Please note that your CI may need new cached data files for Unicode > Version 14.0.0 / Emoji Version 14.0. These files do not get downloaded=
> in a usual compilation of Ruby to avoid lots of unneeded network traff= ic.
>
> Regards,=C2=A0=C2=A0 Martin.
>
>
> -------- Forwarded Message --------
> Subject: [ruby-cvs:91197] 8f59482f5d (master): add some tests for
> Unicode Version 14.0.0
> Date: Sun, 13 Mar 2022 09:41:37 +0900 (JST)
> From: Martin D=C3=BCrst <duerst@it.aoyama.ac.jp>
> To: ruby-c= vs@ruby-lang.org
>
> Martin D=C3=BCrst=C2=A0=C2=A0=C2=A0 2022-03-12 21:33:51 +0900 (Sat, 12= Mar 2022)
>
>=C2=A0 =C2=A0 New Revision: 8f59482f5d
>
>=C2=A0 =C2=A0 https://github.com/ruby/ruby/commit/= 8f59482f5d
>
>=C2=A0 =C2=A0 Log:
>=C2=A0 =C2=A0=C2=A0=C2=A0 add some tests for Unicode Version 14.0.0
>
>=C2=A0 =C2=A0 Modified files:
>=C2=A0 =C2=A0=C2=A0=C2=A0 test/ruby/test_regexp.rb
>=C2=A0 =C2=A0=C2=A0=C2=A0 test/ruby/test_string.rb.
>
> Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=3Dunsubs= cribe>
> <http://lists.ruby-lang.org/cgi-= bin/mailman/options/ruby-core>

--000000000000b75d7c05da188789-- --===============1457902065== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline ClVuc3Vic2NyaWJlOiA8bWFpbHRvOnJ1YnktY29yZS1yZXF1ZXN0QHJ1YnktbGFuZy5vcmc/c3Vi amVjdD11bnN1YnNjcmliZT4KPGh0dHA6Ly9saXN0cy5ydWJ5LWxhbmcub3JnL2NnaS1iaW4vbWFp bG1hbi9vcHRpb25zL3J1YnktY29yZT4K --===============1457902065==--