From: "aaronjensen (Aaron Jensen)" Date: 2022-03-18T18:22:29+00:00 Subject: [ruby-core:107985] [Ruby master Feature#18648] ruby2_keywords and ... name arguments with impossible names Issue #18648 has been updated by aaronjensen (Aaron Jensen). jeremyevans0 (Jeremy Evans) wrote in #note-1: > This isn't a bug, it's currently expected behavior, even if it is a bit inconsistent. I'll switch this to feature, but if you would like the behavior changed, you'll need to respond with what you would like the behavior changed to. You don't mention what problem was caused downstream, so it's hard to guess what you want. IMO, it seems unlikely the benefits of changing things are worth the backwards compatibility cost. The downstream library effectively copies method signatures. In this instance, it attempted to generate a method signature using the specified name of `:**` which resulted in a method like `def foo(****)`. We've special cased it to ignore names of `*`, `**`, and `&`. That seems like a work-around though to the I don't think I'm in a position to make a suggestion as I don't know all of the ramifications. I can just make an observation that generating parameters that have names that are otherwise impossible (afaict) is surprising. I would have expected that the parameters were unnamed, but even that is inconsistent with the block argument. It may just be what is necessary and `*` and `**` are convenient names *because* they are otherwise impossible. ---------------------------------------- Feature #18648: ruby2_keywords and ... name arguments with impossible names https://bugs.ruby-lang.org/issues/18648#change-96937 * Author: aaronjensen (Aaron Jensen) * Status: Feedback * Priority: Normal ---------------------------------------- While investigating a break in a library using reflection, I realized that when ... is used or ruby2_keywords is used that Ruby will name arguments with their symbol, rather than leaving them unnamed. This test demonstrates the issue: https://github.com/ruby/ruby/blob/97426e15d721119738a548ecfa7232b1d027cd34/test/ruby/test_method.rb#L35 https://github.com/ruby/ruby/blob/97426e15d721119738a548ecfa7232b1d027cd34/test/ruby/test_method.rb#L586 I do not understand how `:*`, `:**`, and `:&` are meant to be considered valid parameter names. I assume the reason is so that they do not conflict with something a person could write but that they can still be referenced in Ruby to facilitate delegation but I just wanted to report that it caused a problem downstream. It's also curious that: ``` def foo(*, **, &) end ``` Gives these parameter: `[[:rest], [:keyrest], [:block, :&]]` Why does only `block` get the faux name? Is it because that's how yield works so there needs to be a way to reference it in Ruby? -- https://bugs.ruby-lang.org/ Unsubscribe: