[ruby-core:108022] [Ruby master Feature#18566] Merge `io-wait` and `io-nonblock` gems into core IO

Issue #18566 has been updated by Eregon (Benoit Daloze).


mame (Yusuke Endoh) wrote in #note-16:
> @akr was against to make io/nonblock built-in because it is a old-style interface for nonblock IOs. He recommended `IO#read_nonblock` and `IO#write_nonblock` instead of the gem.

io/nonblock is useful to tell if an IO is in non-blocking mode and to set it upfront.
This is needed when using a Fiber scheduler but also other cases.
In fact https://bugs.ruby-lang.org/issues/18630#note-9 is another case, read_nonblock/write_nonblock are not useful for that case but checking/setting whether an IO is nonblocking is needed.

In fact `io/nonblock` is so small it's already core in TruffleRuby.
Many core IO methods even need to check/set whether an IO is nonblocking, so it's natural to just use the existing methods for that when such IO methods are written in Ruby.


----------------------------------------
Feature #18566: Merge `io-wait` and `io-nonblock` gems into core IO
https://bugs.ruby-lang.org/issues/18566#change-96980

* Author: byroot (Jean Boussier)
* Status: Open
* Priority: Normal
----------------------------------------
I think we should reconsider status of `io-wait`, and consider simply merging it into core's `IO`.

According to @nobu it's only a gem for "historical" reasons.

Any non trivial IO code will likely make use of it, and it's just 400 lines of code.

Recently with the extraction of `net-protocol`, it was added add a dependency and that caused Ruby 3.1 compatibility issues with some gems (e.g. with [`mail`](https://github.com/mikel/mail/pull/1439)).

### Proposal

  - Merge `io-wait` into `io.c` for Ruby 3.2
  - Remove `io-wait` as a dependency of all gems maintained by `ruby-core` (e.g. `net-protocol`).
  - Publish a new `io-wait` version that is simply an empty gem.
  - Add a `lib/io/wait.rb` stub, with eventually a deprecation warning.

cc @eregon @headius @mame @ioquatix



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>