[#20227] dyna_vars problem? — Tanaka Akira <akr@...17n.org>

しばらく前から、稀に Ruby が core を吐くという問題を追いかけているので

15 messages 2003/05/19
[#20234] Re: dyna_vars problem? — matz@... (Yukihiro Matsumoto) 2003/05/19

まつもと ゆきひろです

[#20236] Re: dyna_vars problem? — Tanaka Akira <akr@...17n.org> 2003/05/19

In article <1053363181.529491.30320.nullmailer@picachu.netlab.jp>,

[ruby-dev:20226] Re: [ruby-cvs] ruby: * array.c (get_inspect_tbl): check whether inspect_tbl value is a

From: nobu.nakada@...
Date: 2003-05-19 12:41:10 UTC
List: ruby-dev #20226
なかだです。

At Mon, 19 May 2003 04:52:56 +0000,
matz wrote:
>     * array.c (get_inspect_tbl): check whether inspect_tbl value is a
>       valid array. (ruby-bugs-ja PR#65)
>     
>     * array.c (inspect_ensure,rb_protect_inspect,rb_inspecting_p):
>       use get_inspect_tbl().

rb_inspecting_p()を使うと常に警告が出ます。

$ ./ruby -e 'p [1]'
-e:1: warning: invalid inspect_tbl value
[1]


Index: array.c
===================================================================
RCS file: /cvs/ruby/src/ruby/array.c,v
retrieving revision 1.120
diff -u -2 -p -r1.120 array.c
--- array.c	19 May 2003 05:41:07 -0000	1.120
+++ array.c	19 May 2003 12:34:03 -0000
@@ -936,8 +936,10 @@ get_inspect_tbl(create)
     VALUE inspect_tbl = rb_thread_local_aref(rb_thread_current(), inspect_key);
 
-    if (create && NIL_P(inspect_tbl)) {
-      tbl_init:
-	inspect_tbl = rb_ary_new();
-	rb_thread_local_aset(rb_thread_current(), inspect_key, inspect_tbl);
+    if (NIL_P(inspect_tbl)) {
+	if (create) {
+	  tbl_init:
+	    inspect_tbl = rb_ary_new();
+	    rb_thread_local_aset(rb_thread_current(), inspect_key, inspect_tbl);
+	}
     }
     else if (TYPE(inspect_tbl) != T_ARRAY) {


-- 
--- 僕の前にBugはない。
--- 僕の後ろにBugはできる。
    中田 伸悦

In This Thread

Prev Next