From: Greg.mpls@...
Date: 2019-06-22T15:37:19+00:00
Subject: [ruby-core:93321] [Ruby trunk Bug#14194] --enable-frozen-string-literal ruby runner.rb cgi
Issue #14194 has been updated by MSP-Greg (Greg L).
File test_mspec_err.log added
File test_all_err.log added
FYI,
Just ran ruby-loco with frozen string. Both test-all & spec are run parallel, and both crashed.
test-all failures/errors before crash:
```
ruby 2.7.0dev (2019-06-22T14:38:07Z master f738eeabc2) [x64-mingw32]
CRASHED?
3 CGIMultipartTest#test_cgi_multipart_without_tempfile = 0.06 s = F
/ruby/test/cgi/test_cgi_multipart.rb:353
1. [2/2] Assertion for "stderr"
| <[]> expected but was
| <["-:20:in `gsub!': can't modify frozen String: \"--foobar1234\\\\nContent-Disposition: form-data: name=\\\\\"name1\\\\\"\\\\n\\\\nvalue1\\\\n--foobar1234\\\\nContent-Disposition: form-data: name=\\\\\"file1\\\\\"; filename=\\\\\"file1.html\\\\\"\\\\nContent-Type: text/html\\\\n\\\\n\\\\nHello
\\\\n\\\\n\\\\n--foobar1234--\\\\n\" (FrozenError)",
| "\tfrom -:20:in `'"]>.
2 TestObjSpace#test_dump_all = 0.04 s = F
/ruby/test/objspace/test_objspace.rb:382
Expected /"bytesize":11, "value":"TEST STRING", "encoding":"UTF-8", "file":"-", "line":4, "method":"dump_my_heap_please", "generation":/ to match "".
4 TestObjSpace#test_reachable_objects_from = 0.14 s = F
/ruby/test/objspace/test_objspace.rb:120
<[Array, "a", "a", "a"]> expected but was
<[Array, "a"]>.
0 Test_String_Fstring#test_singleton_class = 0.00 s = E
/ruby/test/-ext-/string/test_fstring.rb:61
can't modify frozen String: "_206aw_cd7_464323"
```
I can't look at this today, but I attached both STDERR logs which show the output from the crashes.
Thanks, Greg
----------------------------------------
Bug #14194: --enable-frozen-string-literal ruby runner.rb cgi
https://bugs.ruby-lang.org/issues/14194#change-78796
* Author: MSP-Greg (Greg L)
* Status: Feedback
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: ruby 2.5.0dev (2017-12-17 trunk 61304) [x64-mingw32]
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
Assuming `--enable-frozen-string-literal`, `ruby runner.rb cgi`
Running without patch:
```
1) Failure:
CGIMultipartTest#test_cgi_multipart_without_tempfile [E:/GitHub/ruby/test/cgi/test_cgi_multipart.rb:353]:
1. [2/2] Assertion for "stderr"
| <[]> expected but was
| <["-:20:in `gsub!': can't modify frozen String, created at -:5 (FrozenError)",
| "\tfrom -:20:in `'"]>.
Finished tests in 3.042000s, 143.3268 tests/s, 333.3333 assertions/s.
436 tests, 1014 assertions, 1 failures, 0 errors, 0 skips
```
With patch:
```
Finished tests in 2.620800s, 166.3614 tests/s, 386.9048 assertions/s.
436 tests, 1014 assertions, 0 failures, 0 errors, 0 skips
ruby -v: ruby 2.5.0dev (2017-12-17 trunk 61304) [x64-mingw32]
```
---Files--------------------------------
frozen_cgi.patch (740 Bytes)
test_all_err.log (2.04 KB)
test_mspec_err.log (832 Bytes)
--
https://bugs.ruby-lang.org/
Unsubscribe: