[ruby-core:90783] [Ruby trunk Bug#15478][Feedback] [RFC] erb: remove deprecation warnings from ERB.new

From: takashikkbn@...
Date: 2018-12-29 03:06:18 UTC
List: ruby-core #90783
Issue #15478 has been updated by k0kubun (Takashi Kokubun).

Status changed from Open to Feedback

Stop showing warnings for legacy_trim_mode and legacy_eoutvar is fine. But why should we stop deprecating nil and 0 for safe_level? If we do so, this would be suddenly broken in Ruby 2.8 or Ruby 3.0. So this change does not make sense for safe migration.

Note that we already showed this deprecation warning on warnlevel == 2 on Ruby 2.6.

----------------------------------------
Bug #15478: [RFC] erb: remove deprecation warnings from ERB.new
https://bugs.ruby-lang.org/issues/15478#change-75956

* Author: normalperson (Eric Wong)
* Status: Feedback
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
erb: remove deprecation warnings from ERB.new

There's too much code relying on the old ordering; so any
deprecation or removal of the old way is too annoying
and only serves to make users angry.


---Files--------------------------------
0001-erb-remove-deprecation-warnings-from-ERB.new.patch (2.87 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next