From: Xavier Noria <fxn@...>
Date: 2018-12-27T07:36:43+01:00
Subject: [ruby-core:90741] possible bug with hacked autoload path and	classes/modules

--===============1219504053==
Content-Type: multipart/alternative; boundary="000000000000a86ed1057dfb2d11"

--000000000000a86ed1057dfb2d11
Content-Type: text/plain; charset="UTF-8"

Hey, I am experimenting with decorated Kernel#require and hacked paths, and
while everything works as expected, this use case doesn't:

  module Kernel
    alias original_require require
    def require(path)
      if path == "hacked"
        original_require("user")
      else
        original_require(path)
      end
    end
  end

  Object.autoload(:User, "hacked")
  User

In user.rb we have "class User; end" and the error message is

  uninitialized constant User (NameError)
  Did you mean?  User

Note that we are suggested User!

If "user.rb" contains "User = 1" or "User = Class.new", no problem.

Also, it is interesting that if we define the autoload in the decoration
again:

  module Kernel
    alias original_require require
    def require(path)
      if path == "hacked"
        Object.autoload(:User, "user")
        original_require("user")
      else
        original_require(path)
      end
    end
  end

  Object.autoload(:User, "hacked")
  User

it works fine too, the User class is loaded.

Could that be a bug in the autoload code triggered by the class/module
keywords?

--000000000000a86ed1057dfb2d11
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div>He=
y, I am experimenting with decorated Kernel#require and hacked paths, and w=
hile everything works as expected, this use case doesn&#39;t:</div><div><br=
></div><div><span style=3D"font-family:monospace,monospace">=C2=A0 module K=
ernel<br>=C2=A0=C2=A0=C2=A0 alias original_require require<br>=C2=A0=C2=A0=
=C2=A0 def require(path)<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if path =3D=3D &=
quot;hacked&quot;<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 original_re=
quire(&quot;user&quot;)<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else<br>=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 original_require(path)<br>=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 end<br>=C2=A0=C2=A0=C2=A0 end<br>=C2=A0 end<br><br>=C2=A0 O=
bject.autoload(:User, &quot;hacked&quot;)<br>=C2=A0 User</span><br></div><d=
iv><br></div><div>In user.rb we have &quot;class User; end&quot; and the er=
ror message is</div><div><br></div><div><span style=3D"font-family:monospac=
e,monospace">=C2=A0 uninitialized constant User (NameError)</span></div><di=
v><span style=3D"font-family:monospace,monospace">=C2=A0 Did you mean?=C2=
=A0 User</span></div><div><br></div><div>Note that we are suggested User!</=
div><div><br></div><div>If &quot;user.rb&quot; contains &quot;User =3D 1&qu=
ot; or &quot;User =3D Class.new&quot;, no problem. <br></div><div><br></div=
><div>Also, it is interesting that if we define the autoload in the decorat=
ion again:</div><div><br></div><div><span style=3D"font-family:monospace,mo=
nospace">=C2=A0 module Kernel<br>=C2=A0=C2=A0=C2=A0 alias original_require =
require<br>=C2=A0=C2=A0=C2=A0 def require(path)<br>=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 if path =3D=3D &quot;hacked&quot;<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 Object.autoload(:User, &quot;user&quot;)<br>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 original_require(&quot;user&quot;)<br>=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 else<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 origi=
nal_require(path)<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 end<br>=C2=A0=C2=A0=C2=
=A0 end<br>=C2=A0 end</span></div><div><span style=3D"font-family:monospace=
,monospace"><br></span></div><div><span style=3D"font-family:monospace,mono=
space"><span style=3D"font-family:monospace,monospace">=C2=A0 Object.autolo=
ad(:User, &quot;hacked&quot;)<br>=C2=A0 User</span></span></div><div><br></=
div><div>it works fine too, the User class is loaded.</div><div><br></div><=
div>Could that be a bug in the autoload code triggered by the class/module =
keywords?</div><div><br></div><div><br></div><div><br></div></div></div></d=
iv></div>

--000000000000a86ed1057dfb2d11--

--===============1219504053==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

--===============1219504053==--