From: eregontp@... Date: 2017-12-27T19:07:45+00:00 Subject: [ruby-core:84524] [Ruby trunk Misc#14222] Mutex.lock is not safe inside signal handler: what is? Issue #14222 has been updated by Eregon (Benoit Daloze). Could MRI simply use the self-pipe trick or similar internally, and execute signal handlers on the main thread by using Ruby's interrupts? (RUBY_VM_CHECK_INTS) A bit like Thread#raise except it would execute the signal handler instead of throwing an exception. That would allow to run any kind of code in signal handlers. The timer thread could listen for signals and interrupt the main thread to execute the handler, since that code is likely not async-signal safe. Of course, it doesn't solve the problem of calling SOME_LOCK.lock in the handler if SOME_LOCK is already locked by the main Thread. But that seems rarely a problem, and internal locks could be reentrant (e.g. IO locks). Having a not-well defined set of allowed operations in a Ruby block (the signal handler) seems a much larger problem worth fixing. P.S.: That's what is done in TruffleRuby essentially. ---------------------------------------- Misc #14222: Mutex.lock is not safe inside signal handler: what is? https://bugs.ruby-lang.org/issues/14222#change-69052 * Author: hkmaly (Honza Maly) * Status: Open * Priority: Normal * Assignee: ruby-core ---------------------------------------- As mentioned in #7917, Mutex.lock is not safe inside signal handler. As mentioned in #6416, neither is Thread.join. But there seem to be no documentation about what IS safe to do inside signal handler. In C, it is not safe to just modify variable inside signal handler without locking. Is it safe in ruby in case of 1) global variable 2) class variable 3) object variable 4) thread local variable, as in Thread.current['local_var'] ? Is there any other method of locking usable inside trap content? Note that while response in this issue would be useful it would be even better if it appeared in official ruby documentation, if there is any. I realize it is not directly bug but it's likely going to be cause of many bugs if the answer is "no" on any part of this and only people who understand ruby core can answer this. -- https://bugs.ruby-lang.org/ Unsubscribe: