From: Greg.mpls@... Date: 2017-12-11T14:07:17+00:00 Subject: [ruby-core:84160] [Ruby trunk Bug#14165] 61096 - support 128bit ino on Windows (if available) - MinGW Problems - compile & fiddle / libffi Issue #14165 has been updated by MSP-Greg (Greg L). @kubo, Thank you for the patch. That does allow MinGW to build. I'll add it to ruby-loco. Both my system, ruby-loco, and Lars Kanis' RubyInstaller2 use MSYS2/MinGW. The current gcc version in that system is 7.2.0. I've gotten the impression that the warning/error settings for it are set 'tighter' than many of the other compilers currently used for Ruby. Two questions: 1. Is this a MinGW issue, or an issue with gcc 'rejecting' the code? 2. The patch appears to avoid the new (and better?) definition if it's a MinGW build, but the definition seems to work with both vc120 and vc140 builds. Is it possible to adjust the code avoid the double definition, rather than disallowing it? I don't know if this feature is OS version dependent, but I thought some of the recent file time patches did make use of OS versioning in their defs... Reminder, I'm not a c type, so please forgive me if this is totally wrong. Thanks again for the patch, Greg ---------------------------------------- Bug #14165: 61096 - support 128bit ino on Windows (if available) - MinGW Problems - compile & fiddle / libffi https://bugs.ruby-lang.org/issues/14165#change-68266 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.5.0dev (2017-12-11 trunk 61097) [x64-mingw32] * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Last ruby-loco build has warnings & test failures after 61097. Build log (attached) has 329 instances of: ``` include/ruby/win32.h:197:0: warning: "SIZEOF_STRUCT_STAT_ST_INO" redefined ``` Same issue with test failures (attached as 61097_test-all_issues.log) Thanks, Greg ---Files-------------------------------- 61097_test-all_issues.log (23.8 KB) 61097_ruby25_64-build.log (333 KB) sizeof_st_ino_on_mingw32.patch (719 Bytes) -- https://bugs.ruby-lang.org/ Unsubscribe: