From: shyouhei@...
Date: 2017-01-18T00:48:00+00:00
Subject: [ruby-core:79109] [Ruby trunk Bug#13134] Rational() inconsistency

Issue #13134 has been updated by Shyouhei Urabe.


I don't think `Rational("3.1/2.0")` should introduce imprecision because the argument string has nothing to do with inexact numbers (at least seems to me).

So Eli's argument is ultimately "should we hold (a/b).to_r == Rational("#{a}/#{b}") ?"  and I think this is a valid argument.  No opinion on this point though.

----------------------------------------
Bug #13134: Rational() inconsistency
https://bugs.ruby-lang.org/issues/13134#change-62516

* Author: Nobuyoshi Nakada
* Status: Assigned
* Priority: Normal
* Assignee: Kenta Murata
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
`Rational()` parses a float, an integer divided by an integer, and a float divided by an integer.

```ruby
Rational("3.1")     #=> (31/10)
Rational("3/2")     #=> (3/2)
Rational("3.1/2")   #=> (31/20)
```
But a float is not allowed as a denominator.

```ruby
Rational("3.1/2.0") #=> ArgumentError
```

I'd expect the last also passes and results in `(31/20)`, or the third also raises an `ArgumentError`

A patch to let all pass.
https://github.com/ruby/ruby/compare/trunk...nobu:parse_rat



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>