[#78949] [Ruby trunk Feature#13095] [PATCH] io.c (rb_f_syscall): remove deprecation notice — kosaki.motohiro@...
Issue #13095 has been updated by Motohiro KOSAKI.
3 messages
2017/01/03
[#78997] [Ruby trunk Bug#13110] Byte-based operations for String — shugo@...
Issue #13110 has been updated by Shugo Maeda.
3 messages
2017/01/06
[#79228] Re: [ruby-cvs:64576] naruse:r57410 (trunk): Prevent GC by volatile [Bug #13150] — Eric Wong <normalperson@...>
naruse@ruby-lang.org wrote:
5 messages
2017/01/23
[#79511] Re: [ruby-cvs:64576] naruse:r57410 (trunk): Prevent GC by volatile [Bug #13150]
— Eric Wong <normalperson@...>
2017/02/13
Eric Wong <normalperson@yhbt.net> wrote:
[#79518] Re: [ruby-cvs:64576] naruse:r57410 (trunk): Prevent GC by volatile [Bug #13150]
— Nobuyoshi Nakada <nobu@...>
2017/02/13
On 2017/02/13 10:04, Eric Wong wrote:
[#79298] [Ruby trunk Bug#13085][Assigned] io.c io_fwrite creates garbage — nobu@...
Issue #13085 has been updated by Nobuyoshi Nakada.
3 messages
2017/01/29
[#79337] Re: [ruby-changes:45397] normal:r57469 (trunk): io.c: recycle garbage on write — SASADA Koichi <ko1@...>
Eric:
4 messages
2017/01/31
[#79352] Re: [ruby-changes:45397] normal:r57469 (trunk): io.c: recycle garbage on write
— Eric Wong <normalperson@...>
2017/01/31
SASADA Koichi <ko1@atdot.net> wrote:
[ruby-core:78975] Re: [Ruby trunk Bug#13085] io.c io_fwrite creates garbage
From:
Eric Wong <normalperson@...>
Date:
2017-01-05 03:22:06 UTC
List:
ruby-core #78975
nobu@ruby-lang.org wrote:
> No.
> Your patch releases the GVL while unfreezing the string to be written.
> If the write operation is blocked, other threads can clobber that string.
It does?
fwrite_unfreeze happens in rb_ensure e_proc, which has GVL.
From what I can tell, GVL release happens only inside
fwrite_freeze (rb_ensure b_proc):
fwrite_freeze (rb_ensure b_proc)
io_binwrite
rb_mutex_synchronize(fptr->write_lock...)
rb_mutex_lock = NOGVL
io_binwrite_string (identical as below:)
io_binwrite_string
rb_writev_internal
rb_thread_io_blocking_region = NOGVL
rb_write_internal
rb_thread_io_blocking_region = NOGVL
rb_io_wait_writable = NOGVL
By the time e_proc (fwrite_unfreeze) is called by rb_ensure
we have GVL, again.
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>