[ruby-core:55303] [ruby-trunk - Bug #8488] Refactor rbinstall.rb for maintenance, clarity, reuse

Issue #8488 has been updated by headius (Charles Nutter).


Here is a first pass breaking rbinstall.rb into a set of component libraries and reducing the use of global state. Starting to look a bit more like a library, which I think is what we want.

There's no functionality change in this patch...I merely broke rbinstall.rb up into chunks and reworked how it executes. Tested with "make install" on my local system, and all appears to install properly.

https://gist.github.com/headius/5706190
----------------------------------------
Bug #8488: Refactor rbinstall.rb for maintenance, clarity, reuse
https://bugs.ruby-lang.org/issues/8488#change-39694

Author: headius (Charles Nutter)
Status: Open
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: build
Target version: 
ruby -v: 2.1dev
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


tool/rbinstall.rb is used to install many parts of Ruby at "make install" time, but it has grown to a rather cumbersome size. It also houses some logic that could/should be reused by other implementations, like the default gem installation.

I would like to do some cleanup and refactoring of this file to make it easier to maintain. I'd also like to factor out the default gems logic into a separate piece of code that can be used outside of rbinstall, for e.g. JRuby.

A number of folks have contributed to this file, but kou and nobu seem to be the primary maintainers.


-- 
http://bugs.ruby-lang.org/