[ruby-core:55290] Re: [ruby-changes:28951] zzak:r41003 (trunk): * process.c: Improve Process::exec documentation

On Jun 3, 2013, at 9:53 PM, Zachary Scott wrote:

> I fail to see the difference, please provide a patch to make it more clear.

Do you want a patch providing alternate and less ambiguous wording or a patch making the difference between the original (pre-r41003) and new (as of r41003) more clear?

For the latter, just go to:

http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/process.c?r1=41003&r2=41002&pathrev=41003&view=patch

It's a large chunk, but in it you will find these three new lines:

+ *  The standard shell always means <code>"/bin/sh"</code> on Unix-like systems,
+ *  same as <code>ENV["RUBYSHELL"]</code>
+ *  (or <code>ENV["COMSPEC"]</code> on Windows NT series), and similar.

...that replaced these three old lines:

- *  The standard shell means always <code>"/bin/sh"</code> on Unix-like systems,
- *  <code>ENV["RUBYSHELL"]</code> or <code>ENV["COMSPEC"]</code> on Windows NT series, and
- *  similar.

In addition to swapping the order of "means always" to "always means" on the first line, the new text has also added "same as" to the beginning of the second line, added a "(" before "or", and added a ")" after "series".  The old wording does not contain the words "same as" nor does it contain "(" or ")".

For the former, here is a variation (in pseudo-patch format) of my earlier suggestion from ruby-core:55278.  It needs additional details regarding Windows behavior:

- *  The standard shell always means <code>"/bin/sh"</code> on Unix-like systems,
- *  same as <code>ENV["RUBYSHELL"]</code>
- *  (or <code>ENV["COMSPEC"]</code> on Windows NT series), and similar.
+ *  The meaning of "standard shell" is OS dependent.  On Unix-like systems
+ *  it always means <code>/bin/sh</code>.  On Windows systems it means
+ *  either <code>ENV["RUBYSHELL"]</code> or <code>ENV["COMSPEC"]</code>
+ *  depending on...

Hope this helps,
Dave