Re: possible bug: stack dump with <<-String, #{...} and large loops

Hi,

At Sat, 25 May 2002 18:26:16 +0900,
ts wrote:
>  it will not work.

Oops.  Throw awy the second added line.

Index: eval.c
===================================================================
RCS file: /cvs/ruby/src/ruby/eval.c,v
retrieving revision 1.295
diff -u -2 -p -r1.295 eval.c
--- eval.c	2002/05/21 05:39:18	1.295
+++ eval.c	2002/05/26 10:54:32
@@ -3074,4 +3074,5 @@ rb_eval(self, n)
 			ruby_sourceline = nd_line(node);
 			ruby_in_eval++;
+			rb_dvar_push(0, 0);
 			list->nd_head = compile(list->nd_head->nd_lit,
 						ruby_sourcefile,

>  Something like this (I *really* don't like it), without the patch to eval.c

Failed at rubicon/language/TestEval.rb.

$ ./i686-linux/miniruby ../rubicon/language/TestEval.rb 
TestEval#testBasicEval F.
TestEval#testEvalModuleBinding .
TestEval#testEvalNameError .
TestEval#testEvalScoping .
TestEval#testEvalWithBinding .
TestEval#testEvalWithProcBinding E.
TestEval#testProcMoreFunWithBinding .
TestEval#testProcNestedBinding .
Time: 0.01597
FAILURES!!!
Test Results:
 Run: 8/8(21 asserts) Failures: 1 Errors: 1
Failures: 1
../rubicon/language/TestEval.rb:7:in `testBasicEval'(TestEval): expected:<nil> but was:<false> (RUNIT::AssertionFailedError)
        from ../rubicon/language/../rubicon_tests.rb:241:in `handleTests'
        from ../rubicon/language/TestEval.rb:135
Errors: 1
../rubicon/language/TestEval.rb:70:in `eval'(TestEval): (eval):1:in `testEvalWithProcBinding': undefined local variable or method `i4' for #<TestEval:0x4023a69c> (NameError)
        from ../rubicon/language/TestEval.rb:70:in `testEvalWithProcBinding'
        from ../rubicon/language/../rubicon_tests.rb:241:in `handleTests'
        from ../rubicon/language/TestEval.rb:135


> pigeon% diff -u node.h.old node.h
> --- node.h.old  Sat May 25 11:01:51 2002
> +++ node.h      Sat May 25 11:01:56 2002
> @@ -267,8 +267,8 @@
>  #define NEW_MASGN(l,r)   rb_node_newnode(NODE_MASGN,l,0,r)
>  #define NEW_GASGN(v,val) rb_node_newnode(NODE_GASGN,v,val,rb_global_entry(v))
>  #define NEW_LASGN(v,val) rb_node_newnode(NODE_LASGN,v,val,local_cnt(v))
> -#define NEW_DASGN(v,val) rb_node_newnode(NODE_DASGN,v,val,0);
> -#define NEW_DASGN_CURR(v,val) rb_node_newnode(NODE_DASGN_CURR,v,val,0);
> +#define NEW_DASGN(v,val) rb_node_newnode(NODE_DASGN,v,val,0)
> +#define NEW_DASGN_CURR(v,val) rb_node_newnode(NODE_DASGN_CURR,v,val,0)
>  #define NEW_IASGN(v,val) rb_node_newnode(NODE_IASGN,v,val,0)
>  #define NEW_CDECL(v,val) rb_node_newnode(NODE_CDECL,v,val,0)
>  #define NEW_CVASGN(v,val) rb_node_newnode(NODE_CVASGN,v,val,0)

You're right.

-- 
Nobu Nakada