From: "LevLukomskyi (Lev Lukomskyi)" Date: 2022-08-25T11:36:54+00:00 Subject: [ruby-core:109686] [Ruby master Feature#18959] Handle gracefully nil kwargs eg. **nil Issue #18959 has been updated by LevLukomskyi (Lev Lukomskyi). > I meant to simply use compact! in a different statement, not in a chain. If use `compact!` as a different statement then you need to make a variable, you have to make a mental effort to make up the name for that variable and repeat its name to use `compact!`. Also, you have to repeat that variable at the end to return the resulting hash, since we are building the hash to use it somewhere, so in the end: ```ruby res = { some: 'value', id: id.presence, } res.compact! res ``` vs ```ruby { some: 'value', **({ id: id } if id.present?), } ``` While the first option looks like a bunch of instructions, the second option looks like a hash with plugged another hash ��� the intent is clearer. The same with another example: ```ruby res = { some: 'value', } res.merge!(id: id, name: name) if id.present? res ``` vs ```ruby { some: 'value', **({ id: id, name: name } if id.present?), } ``` The second option looks more concise to me. ---------------------------------------- Feature #18959: Handle gracefully nil kwargs eg. **nil https://bugs.ruby-lang.org/issues/18959#change-98910 * Author: LevLukomskyi (Lev Lukomskyi) * Status: Open * Priority: Normal ---------------------------------------- The issue: ```ruby def qwe(a: 1) end qwe(**nil) #=> fails with `no implicit conversion of nil into Hash (TypeError)` error { a:1, **nil } #=> fails with `no implicit conversion of nil into Hash (TypeError)` error ``` Reasoning: I found myself that I often want to insert a key/value to hash if a certain condition is met, and it's very convenient to do this inside hash syntax, eg.: ```ruby { some: 'value', **({ id: id } if id.present?), } ``` Such syntax is much more readable than: ```ruby h = { some: 'value' } h[:id] = id if id.present? h ``` Yes, it's possible to write like this: ```ruby { some: 'value', **(id.present? ? { id: id } : {}), } ``` but it adds unnecessary boilerplate noise. I enjoy writing something like this in ruby on rails: ```ruby content_tag :div, class: [*('is-hero' if hero), *('is-search-page' if search_page)].presence ``` If no conditions are met then the array is empty, then converted to nil by `presence`, and `class` attribute is not rendered if it's nil. It's short and so convenient! There should be a similar way for hashes! I found this issue here: https://bugs.ruby-lang.org/issues/8507 where "consistency" thing is discussed. While consistency is the right thing to do, I think the main point here is to have fun with programming, and being able to write stuff in a concise and readable way. Please, add this small feature to the language, that'd be so wonderful! ���� -- https://bugs.ruby-lang.org/ Unsubscribe: