From: deivid.rodriguez@...
Date: 2021-05-25T19:13:29+00:00
Subject: [ruby-core:104049] [Ruby master Feature#17883] Load bundler/setup earlier to make `bundle exec ruby -r` respect Gemfile

Issue #17883 has been updated by deivid (David Rodr�guez).


Just to clarify my previous comment.

Unconditionally enabling bundler everytime `ruby` is used (i.e., from `rubygems.rb`) is not even on the table. I only made some progress on making the `RUBYGEMS_GEMDEPS` environment variable optionally enable `bundler` from `rubygems` binstubs, so that if you for example run `rails -v` from within an application with a `Gemfile`, it will print the Rails version of your app, whereas if you run it outside of a Gemfile context, it will work as it works today and print the highest `rails` version installed globally on your system.

But this is opt-in only through `ENV` and does not affect regular ruby scripts (just binstubs) nor non-Gemfile contexts.

----------------------------------------
Feature #17883: Load bundler/setup earlier to make `bundle exec ruby -r` respect Gemfile
https://bugs.ruby-lang.org/issues/17883#change-92187

* Author: mame (Yusuke Endoh)
* Status: Rejected
* Priority: Normal
----------------------------------------
To reproduce the issue, prepare a Gemfile and run `bundle install --path=vendor/bundle`.

```
$ cat Gemfile
source "https://rubygems.org"
gem "activesupport"

$ bundle install --path=vendor/bundle
```

`Kernel#require` respects the Gemfile correctly.

```
$ bundle exec ruby -e 'require "active_support"'
```

However, `bundle exec ruby -ractive_support -e ''` does not.

```
$ bundle exec ruby -ractive_support -e ''
<internal:/home/mame/work/ruby/local/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- active_support (LoadError)
        from <internal:/home/mame/work/ruby/local/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
```

We can work around the issue by explicitly passing `-rbundler/setup` before `-ractive_support`, but this is very confusing to me. The same issue was discussed in StackOverflow: https://stackoverflow.com/questions/59623068/correct-way-to-combine-bundle-exec-and-ruby-r

---

Here is my analysis. `bundle exec` sets `RUBYOPT=-rbundler/setup` which replaces `Kernel#require` with bundler's own definition. `-e 'require "active_support"'` correctly triggers bundler's definition. However, `-ractive_support` is evaluated before `RUBYOPT=-rbundler/setup` is evaluated, so it triggers rubygems' require definition which does not know `vendor/bundle` directory.

This is caused by the interpretation order of `RUBYOPT` and command-line arguments.

```
$ RUBYOPT=-r./a ruby -r./b -e ''
:b
:a
```

For compatibility, I don't think that changing the order is a good idea. IMO, it would be good for ruby interpreter to provide Bundler something special, because Bundler is now bundled with Ruby.

My naive idea is to make the interpreter load `ENV["BUNDLE_BIN_PATH"] + "../../lib/bundler/setup"` before any other `-r` options if `BUNDLE_BIN_PATH` is defined. Or another new dedicated environment variable that `bundle exec` sets may work (for example, `RUBY_BUNDLER_SETUP` or something).

@deivid @nobu What do you think?



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>