From: merch-redmine@... Date: 2021-05-25T14:50:00+00:00 Subject: [ruby-core:104039] [Ruby master Feature#17883] Load bundler/setup earlier to make `bundle exec ruby -r` respect Gemfile Issue #17883 has been updated by jeremyevans0 (Jeremy Evans). mame (Yusuke Endoh) wrote in #note-10: > BTW, I noticed that my patch could be even much simpler. If you like `BUNDLER_SETUP`: > > ```diff > diff --git a/lib/rubygems.rb b/lib/rubygems.rb > index 3585defd2d..65f34d8812 100644 > --- a/lib/rubygems.rb > +++ b/lib/rubygems.rb > @@ -1366,3 +1366,7 @@ def default_gem_load_paths > require 'rubygems/core_ext/kernel_warn' > > Gem.use_gemdeps > + > +require "bundler/setup" if ENV["BUNDLER_SETUP"] > ``` While I still prefer a more generic approach, I'm OK with this idea as it allows the user to opt-in to the use of bundler by setting an environment variable. > (This is off-topic: Nowadays, many people are using Bundler, so it might be a good time to enable Bundler by default? We can start it with `require "bundler/setup" unless ENV["NO_BUNDLER"]` :-) I'm against this in the strongest possible terms. There are more ruby scripts not using bundler than there are ruby applications using bundler. We should not force the usage of bundler and require users to opt-out of it. We should use an opt-in approach. ---------------------------------------- Feature #17883: Load bundler/setup earlier to make `bundle exec ruby -r` respect Gemfile https://bugs.ruby-lang.org/issues/17883#change-92177 * Author: mame (Yusuke Endoh) * Status: Open * Priority: Normal ---------------------------------------- To reproduce the issue, prepare a Gemfile and run `bundle install --path=vendor/bundle`. ``` $ cat Gemfile source "https://rubygems.org" gem "activesupport" $ bundle install --path=vendor/bundle ``` `Kernel#require` respects the Gemfile correctly. ``` $ bundle exec ruby -e 'require "active_support"' ``` However, `bundle exec ruby -ractive_support -e ''` does not. ``` $ bundle exec ruby -ractive_support -e '' :85:in `require': cannot load such file -- active_support (LoadError) from :85:in `require' ``` We can work around the issue by explicitly passing `-rbundler/setup` before `-ractive_support`, but this is very confusing to me. The same issue was discussed in StackOverflow: https://stackoverflow.com/questions/59623068/correct-way-to-combine-bundle-exec-and-ruby-r --- Here is my analysis. `bundle exec` sets `RUBYOPT=-rbundler/setup` which replaces `Kernel#require` with bundler's own definition. `-e 'require "active_support"'` correctly triggers bundler's definition. However, `-ractive_support` is evaluated before `RUBYOPT=-rbundler/setup` is evaluated, so it triggers rubygems' require definition which does not know `vendor/bundle` directory. This is caused by the interpretation order of `RUBYOPT` and command-line arguments. ``` $ RUBYOPT=-r./a ruby -r./b -e '' :b :a ``` For compatibility, I don't think that changing the order is a good idea. IMO, it would be good for ruby interpreter to provide Bundler something special, because Bundler is now bundled with Ruby. My naive idea is to make the interpreter load `ENV["BUNDLE_BIN_PATH"] + "../../lib/bundler/setup"` before any other `-r` options if `BUNDLE_BIN_PATH` is defined. Or another new dedicated environment variable that `bundle exec` sets may work (for example, `RUBY_BUNDLER_SETUP` or something). @deivid @nobu What do you think? -- https://bugs.ruby-lang.org/ Unsubscribe: