[#104004] [Ruby master Feature#17883] Load bundler/setup earlier to make `bundle exec ruby -r` respect Gemfile — mame@...
Issue #17883 has been reported by mame (Yusuke Endoh).
21 messages
2021/05/24
[ruby-core:103916] [Ruby master Bug#17870] `make --output-sync=line install` breaks installation
From:
xtkoba+ruby@...
Date:
2021-05-20 11:57:18 UTC
List:
ruby-core #103916
Issue #17870 has been updated by xtkoba (Tee KOBAYASHI).
I noticed `-Onone` is also troublesome. Other `-O[type]`'s (type being `target` and `recurse`) seem safe to use.
Proposed patch:
```diff
--- a/tool/rbinstall.rb
+++ b/tool/rbinstall.rb
@@ -113,6 +113,7 @@
$make, *rest = Shellwords.shellwords($make)
$mflags.unshift(*rest) unless rest.empty?
$mflags.unshift(*mflags)
+ $mflags -= ['-Oline', '-Onone']
def $mflags.set?(flag)
grep(/\A-(?!-).*#{flag.chr}/i) { return true }
```
----------------------------------------
Bug #17870: `make --output-sync=line install` breaks installation
https://bugs.ruby-lang.org/issues/17870#change-92046
* Author: xtkoba (Tee KOBAYASHI)
* Status: Open
* Priority: Normal
* ruby -v: ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-linux]
* Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
It is reported in https://bugs.gentoo.org/show_bug.cgi?id=790272 that `make --output-sync=line install` installs nearly nothing, and I can confirm this for Ruby 3.0.1p64.
The argument `-Oline` seems to be somehow troublesome in `--mflags` and/or `--make-flags` options for `tool/rbinstall.rb`:
```
./miniruby -I../lib -I. -I.ext/common ../tool/runruby.rb --extout=.ext -- --disable-gems -r./x86_64-linux-fake ../tool/rbinstall.rb --make="make" --dest-dir="" --extout=".ext" --mflags="-Oline" --make-flags=" -Oline" --data-mode=0644 --prog-mode=0755 --installed-list .installed.list --mantype="doc" --exclude=doc
```
Can this be filtered out?
P.S. There might be other troublesome arguments besides `-Oline`, but I have not tested.
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>