[ruby-core:96202] [Ruby master Bug#15425] Store MJIT header into Ruby versioned directory.

From: v.ondruch@...
Date: 2019-12-11 14:41:21 UTC
List: ruby-core #96202
Issue #15425 has been updated by vo.x (Vit Ondruch).


> So maybe respecting --with-ruby-version in the header file name (or removing the version fragment) is the only thing we need to discuss/implement here?

That would be good start. The version there is probably useless.

This is the configuration I used:

~~~
$ ./configure --with-ruby-version='foo'
~~~

And this is the result:

~~~
$ cd /usr/local/include/
$ tree
.
└── ruby-foo
    ├── ruby
    │   ├── assert.h
    │   ├── backward
    │   │   ├── classext.h
    │   │   ├── cxxanyargs.hpp
    │   │   ├── rubyio.h
    │   │   ├── rubysig.h
    │   │   ├── st.h
    │   │   └── util.h
    │   ├── backward.h
    │   ├── debug.h
    │   ├── defines.h
    │   ├── digest.h
    │   ├── encoding.h
    │   ├── intern.h
    │   ├── io.h
    │   ├── missing.h
    │   ├── onigmo.h
    │   ├── oniguruma.h
    │   ├── regex.h
    │   ├── re.h
    │   ├── ruby.h
    │   ├── st.h
    │   ├── subst.h
    │   ├── thread.h
    │   ├── thread_native.h
    │   ├── util.h
    │   ├── version.h
    │   └── vm.h
    ├── ruby-
    │   └── x86_64-linux
    ├── ruby.h
    └── x86_64-linux
        ├── rb_mjit_min_header-2.7.0.h
        └── ruby
            └── config.h

7 directories, 30 files
~~~

----------------------------------------
Bug #15425: Store MJIT header into Ruby versioned directory.
https://bugs.ruby-lang.org/issues/15425#change-83090

* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* Target version: 
* ruby -v: ruby 2.6.0rc2 (2018-12-15 trunk 66408) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
This is a followup of #15391 which fixes JIT to respect the configuration options. However, I still wonder, why the file is versioned and why it is not stored in the versioned directory alongside all other internal Ruby headers. I believe, that while it now respects the header configuration flags, it still does not respect options such as "--with-ruby-version"



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next