From: John W Higgins Date: 2019-12-01T09:14:02-08:00 Subject: [ruby-core:96047] Re: [ruby-trunk - Feature #9602] Logic with `Enumerable#grep` --===============1896682691== Content-Type: multipart/alternative; boundary="000000000000940dfc0598a79716" --000000000000940dfc0598a79716 Content-Type: text/plain; charset="UTF-8" On Tue, Apr 1, 2014 at 8:50 PM wrote: > Issue #9602 has been updated by Sam Rawlins. > > > I've updated my patch some more with Enumerable#reject and Array#reject. > (Array#reject was weird... I reabsorbed `ary_reject()` into > `rb_ary_reject()` and left the only use of `rb_ary_push_1()` intact. I > think some of this code was very old.) > > This looks excellent - but the docs for reject changed the following "... for which the given block is not true" to ".. for which the given block returns a false value" I think the "not true" wording may be better because nils are caught in the reject code. Thanks again for the work - it looks excellent. John --000000000000940dfc0598a79716 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Apr 1, 2014 at 8:50 PM <sam.rawlins@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">Issue #9602 has been updat= ed by Sam Rawlins.


I've updated my patch some more with Enumerable#reject and Array#reject= . (Array#reject was weird... I reabsorbed `ary_reject()` into `rb_ary_rejec= t()` and left the only use of `rb_ary_push_1()` intact. I think some of thi= s code was very old.)


This looks excellent - but the docs fo= r reject changed the following

"...=C2=A0for = which the given=C2=A0block is not true&q= uot;

to

".. f= or which the given block returns a false value"

I think the "not true" = wording may be better because nils are caught in the reject code.

Thanks again = for the work - it looks excellent.

John=
--000000000000940dfc0598a79716-- --===============1896682691== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Unsubscribe: --===============1896682691==--