From: merch-redmine@...
Date: 2019-07-23T03:12:45+00:00
Subject: [ruby-core:93876] [Ruby master Bug#10466] rb_eval_string_wrap does not actually wrap in a module binding

Issue #10466 has been updated by jeremyevans0 (Jeremy Evans).

File rb_eval_string_wrap_cref.patch added

I agree this a bug.  The documentation states for `rb_eval_string_wrap` that `This is same as the binding for loaded libraries on "load('foo', true)"`, but that doesn't appear to be the case. `load('foo', true)` evaluates with an anonymous module in `Module.nesting`, but `rb_eval_string_wrap` uses an empty `Module.nesting`.

The attached patch should fix the issue by setting a cref, so that `rb_eval_string_wrap` evaluates the string with an anonymous module in `Module.nesting`.  I'm not sure if this is the best way to fix it, and would appreciate if another committer could review this patch.  Unfortunately, there are no tests for the `rb_eval_string_wrap` function and nothing internally seems to use this method.

----------------------------------------
Bug #10466: rb_eval_string_wrap does not actually wrap in a module binding
https://bugs.ruby-lang.org/issues/10466#change-79840

* Author: silverhammermba (Max Anselm)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.1.4p265 (2014-10-27 revision 48166) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
`rb_eval_string_wrap` says that it "evaluates the given string under a module binding in an isolated binding", but this isn't true.

Run the following:

~~~
#include <ruby.h>

int main(int argc, char* argv[])
{
	ruby_init();

	int state;
	rb_eval_string_protect("X = 2", &state);
	rb_eval_string_wrap("X = 3", &state);
	rb_eval_string_protect("puts X", &state);

	return ruby_cleanup(0);
}
~~~

### Expected:
outputs 2
### Actual:
outputs

~~~
eval:1: warning: already initialized constant X
eval:1: warning: previous definition of X was here
3
~~~

It looks like `rb_eval_string_wrap` _tries_ to wrap it

~~~
    th->top_wrapper = rb_module_new();
    th->top_self = rb_obj_clone(rb_vm_top_self());
    rb_extend_object(th->top_self, th->top_wrapper);
~~~

But it ends up calling `ruby_eval_string_from_file` which uses `rb_vm_top_self()` as `self`, thus undoing the wrapping.

`rb_load` can perform similar wrapping, but there it works properly.


---Files--------------------------------
rb_eval_string_wrap_cref.patch (1.79 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>