From: merch-redmine@... Date: 2019-07-24T18:46:23+00:00 Subject: [ruby-core:93904] [Ruby master Bug#12230] Wrong exception raised when IO.read from a pipe is passed an offset on Windows Issue #12230 has been updated by jeremyevans0 (Jeremy Evans). File win32-seek-espipe.patch added I think we should fix this to make the behavior on Windows consistent with other operating systems. Attached is a patch that attempts to do so. I'm not sure if the approach the patch takes is the best way to fix this. I also don't have a compilation environment on Windows, so a committer that does should probably check that the patch works. ---------------------------------------- Bug #12230: Wrong exception raised when IO.read from a pipe is passed an offset on Windows https://bugs.ruby-lang.org/issues/12230#change-79975 * Author: vais (Vais Salikhov) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.2.4p230 (2015-12-16 revision 53155) [i386-mingw32] * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN ---------------------------------------- When IO.read from a pipe is passed an offset, the expected exception is Errno::ESPIPE, but on Windows Invalid argument (Errno::EINVAL) is raised instead: ``` C:\Users\Administrator\Desktop>C:\Ruby\ruby-2.2.4-i386-mingw32\bin\ruby.exe -ve "p IO.read('|cmd.exe /C echo hello', 1, 1)" ruby 2.2.4p230 (2015-12-16 revision 53155) [i386-mingw32] The process tried to write to a nonexistent pipe. -e:1:in `read': Invalid argument (Errno::EINVAL) from -e:1:in `
' ``` ---Files-------------------------------- win32-seek-espipe.patch (1.17 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: