From: Greg.mpls@... Date: 2019-07-20T03:42:10+00:00 Subject: [ruby-core:93860] [Ruby master Feature#16012] Add a (small) test-install suite? Issue #16012 has been updated by MSP-Greg (Greg L). I understand the issue with several packagers/builders, etc. But, getting things checked in the build here is a start, and we would know that the internal `make install` worked correctly. We don't know that now. The tool could also be used as a check to be used by the other packagers/builders... Should it be part of the make system, or a bash/shell/ps1 script, or a ruby script? Lastly, you make a good point about '--program-suffix, --prefix and DESTDIR etc.' I'm suggesting testing things that are difficult to test without the 'struture' of a true install. You're also suggesting adding checking for the install itself, which I've never had issue with. But I've never used '--program-suffix' or '--prefix'. Nor have I seen the folder structure or contents fail. But they could... ---------------------------------------- Feature #16012: Add a (small) test-install suite? https://bugs.ruby-lang.org/issues/16012#change-79761 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- At various times there has been discussion about whether testing should require `make install`. Although I prefer to do testing using install (vs build), I see it as a choice, and not a requirement. From time to time various issues have arisen that cannot be found with 'build' testing. Often, these issues cause CI test failure with master/trunk/ruby-head in external repos. Sometimes people blame 'Core', other times Travis, or rvm. Regardless, it doesn't look good. So, might a small set of tests that check install functionality be added? It may need to be two separate (but equivalent) scripts. One for *nix, one for Windows. In ruby-loco, I'm using a ps1 script to check that CLI bin files work. As soon as the update is pushed here, I'll add a test for nested bundler commands... -- https://bugs.ruby-lang.org/ Unsubscribe: