[ruby-core:89592] Re: [PATCH] vm_trace.c (postponed_job_register): only hit main thread

From: Eric Wong <normalperson@...>
Date: 2018-10-28 01:37:43 UTC
List: ruby-core #89592
Eric Wong <normalperson@yhbt.net> wrote:
> Koichi Sasada <ko1@atdot.net> wrote:
> > thank you for you patch.
> > but it is not acceptable because "set only main thread" is highly
> > restricted. stackprof doesn't work well.
> > 
> > I'm thinking that making interrupt_flag global.
> 
> That sounds like a better idea.  Can we get rid of
> ec->interrupt_flag entirely? (but keep ec->interrupt_mask)

Nevermind, I guess ec->interrupt_flag is still needed for
pending interrupt (Thread#raise) :<

Downside is checking for interrupts checking two places
instead of one...

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread