From: ruby-core@...
Date: 2018-07-05T21:10:26+00:00
Subject: [ruby-core:87820] [Ruby trunk Bug#14895] Inconsistent constant names when using const_set on a singleton class

Issue #14895 has been updated by marcandre (Marc-Andre Lafortune).


This looks like a bug to me. 

Here's a simplified example:

```
s = Object.new.singleton_class
a = s.const_set(:A, Module.new)       # => #<Module:0x00007fed619915f0>
b = s.class_eval "module B; self end" # => #<Class:0x00007fed6198a020>::B
c = s.const_set(:C, Module.new)       # => #<Class:0x00007fed6198a020>::C
```

`a` and `c` should be treated identically. The right behavior would be for their `name` to be `#<Class:0x...>::A/C`

Note that naming the singleton class afterwards changes all names correctly:

```
S = s # => #<Class:#<Object:0x00007fed6198a1b0>> 
a   # => S::A 
b   # => S::B 
c   # => S::C 
```

----------------------------------------
Bug #14895: Inconsistent constant names when using const_set on a singleton class
https://bugs.ruby-lang.org/issues/14895#change-72838

* Author: silver_phoenix (Pedro Pinto)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.6.0preview2 (2018-05-31 trunk 63539) [x86_64-linux]
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
```
irb(main):001:0> class X; end
=> nil
irb(main):002:0> X.const_set(:Y, Module.new)
=> X::Y
irb(main):003:0> module M; end
=> nil
irb(main):004:0> M.const_set(:N, Module.new)
=> M::N
irb(main):005:0> x = Object.new
=> #<Object:0x000055886ee2b110>
irb(main):006:0> x.singleton_class.const_set(:Z, Module.new)
=> #<Module:0x000055886ec59a80>
irb(main):007:0> x.singleton_class.class_eval "module A; self end"
=> #<Class:0x000055886ec59d00>::A
irb(main):008:0> x.singleton_class.const_set(:B, Module.new)
=> #<Class:0x000055886ec59d00>::B
```

I would expect module `Z` to be named, but the modules only start being named after creating module `A` through the `module` builtin.

For consistency, if module `B` is named, shouldn't module `Z` be named as well?

Also happens in these ruby versions:
`ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]`
`ruby 2.5.1p57 (2018-03-29 revision 63029) [i386-mingw32]`



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>