[#86787] [Ruby trunk Feature#14723] [WIP] sleepy GC — ko1@...

Issue #14723 has been updated by ko1 (Koichi Sasada).

13 messages 2018/05/01
[#86790] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC — Eric Wong <normalperson@...> 2018/05/01

ko1@atdot.net wrote:

[#87095] [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase — ko1@...

Issue #14767 has been updated by ko1 (Koichi Sasada).

9 messages 2018/05/17
[#87096] Re: [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase — Eric Wong <normalperson@...> 2018/05/17

ko1@atdot.net wrote:

[ruby-core:87010] [Ruby trunk Bug#14429] Overzealous escaping of + in Shellwords

From: william@...
Date: 2018-05-13 23:32:19 UTC
List: ruby-core #87010
Issue #14429 has been updated by woodruffw (William Woodruff).


Ping (and confirming that this is still the case on `2.5.1p57`).

----------------------------------------
Bug #14429: Overzealous escaping of + in Shellwords
https://bugs.ruby-lang.org/issues/14429#change-71977

* Author: woodruffw (William Woodruff)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.4.3p205 (2017-12-14 revision 61247) [x86_64-linux-gnu]
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
The `Shellwords` module is currently a little too conservative: `+` isn't a token in Bourne sh[1], but `Shellwords` escapes it anyways.

Actual:

~~~ ruby
>> Shellwords.escape 'foo+bar' #=> "foo\\+bar"
~~~

Expected:

~~~ ruby
>> Shellwords.escape 'foo+bar' #=> "foo+bar"
~~~


I'm reporting this on ruby 2.4.3, but it looks like ruby-trunk is also affected[2].

[1]: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
[2]: https://github.com/ruby/ruby/blob/trunk/lib/shellwords.rb#L150




-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next