[ruby-core:80471] [Ruby trunk Bug#13387] [PATCH]Add parenthesis to fix compile warning to string.c

From: app.fk91@...
Date: 2017-03-29 09:47:07 UTC
List: ruby-core #80471
Issue #13387 has been reported by litmon (Fukuo Kadota).

----------------------------------------
Bug #13387: [PATCH]Add parenthesis to fix compile warning to string.c
https://bugs.ruby-lang.org/issues/13387

* Author: litmon (Fukuo Kadota)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
When editing string.c and execute `make run`, below warnings showed.

```
$ make run
../ruby/string.c:6142:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ruby/string.c:6142:41: note: place parentheses around the '&&' expression to
      silence this warning
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
                                     ^
     (                                                                                      )
../ruby/string.c:6208:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ruby/string.c:6208:41: note: place parentheses around the '&&' expression to
      silence this warning
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
                                     ^
     (                                                                                      )
```

I fixed this warnings using note.
in Github:
https://github.com/ruby/ruby/pull/1570



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next