From: mame@... Date: 2016-07-22T09:54:30+00:00 Subject: [ruby-core:76525] [Ruby trunk Bug#12611] Issues, reported by PVS-Studio static analyzer Issue #12611 has been updated by Yusuke Endoh. Shyouhei Urabe wrote: > - Fragment N1: GetBindingPtr() is a macro that assigns the argued variable. It will cause no actual harm, but I think "`if (bind && ...) {`" seems pointless as OP said. > - Fragment N2: we have our dedicated realloc() implementation that behaves differently than you assume (it bails out for errors). Really? It is `realloc`, not `xrealloc`. I cannot find a macro like "#define realloc ..." in `win32/file.c`. > - Fragment N3: CreateSymbolicLinkW() does return boolean, no data loss. Then, I wonder why `create_symbolic_link_func` is declared so that it returns DWORD. -- Yusuke Endoh ---------------------------------------- Bug #12611: Issues, reported by PVS-Studio static analyzer https://bugs.ruby-lang.org/issues/12611#change-59767 * Author: Pavel Belikov * Status: Open * Priority: Normal * Assignee: * ruby -v: * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN ---------------------------------------- To demonstrate the capabilities of our analyzer, we regularly perform analysis of open source projects. We had recently checked the Ruby MRI project. Here is the link to the article about it: http://www.viva64.com/en/b/0414/ Official page of the analyzer: http://www.viva64.com/en/pvs-studio/ If you have any questions, or if you are interested in the evaluation of our static analyzer or in any other source code quality control services that our company provides, please contact us at support@viva64.com. -- https://bugs.ruby-lang.org/ Unsubscribe: