[ruby-core:76125] [Ruby trunk Bug#12491][Assigned] TestRefinement#test_prepend_after_refine_wb_miss too slow

From: shugo@...
Date: 2016-06-24 06:14:39 UTC
List: ruby-core #76125
Issue #12491 has been updated by Shugo Maeda.

Status changed from Open to Assigned
Assignee set to Shugo Maeda

Christian Hofstaedtler wrote:
> In Debian we've recently enabled the full test suite (make test-all) on all architectures.
> As part of that, we found that TestRefinement#test_prepend_after_refine_wb_miss times out on slower archs (think armhf, mips, ...).
(snip)
> Please consider bumping the timeout and/or excluding the test?

Does the following fix work?

```
diff --git a/test/ruby/test_refinement.rb b/test/ruby/test_refinement.rb
index 1984d2c..c9de8e8 100644
--- a/test/ruby/test_refinement.rb
+++ b/test/ruby/test_refinement.rb
@@ -785,6 +785,9 @@ class C
   eval PrependAfterRefine_CODE
 
   def test_prepend_after_refine_wb_miss
+    if /\A(arm|mips)/ =~ RUBY_PLATFORM
+      skip "too slow cpu"
+    end
     assert_normal_exit %Q{
       GC.stress = true
       10.times{
```

----------------------------------------
Bug #12491: TestRefinement#test_prepend_after_refine_wb_miss too slow
https://bugs.ruby-lang.org/issues/12491#change-59329

* Author: Christian Hofstaedtler
* Status: Assigned
* Priority: Normal
* Assignee: Shugo Maeda
* ruby -v: ruby 2.3.1p112 (2016-04-26) [x86_64-linux-gnu]
* Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: REQUIRED
----------------------------------------
In Debian we've recently enabled the full test suite (make test-all) on all architectures.
As part of that, we found that TestRefinement#test_prepend_after_refine_wb_miss times out on slower archs (think armhf, mips, ...).

```
  Error:
TestRefinement#test_prepend_after_refine_wb_miss:
Timeout::Error: execution of assert_normal_exit expired
pid 30320 exit 1
| -:38:in `block in <main>': NameError
| 	from -:3:in `times'
| 	from -:3:in `<main>'
| 

    /束PKGBUILDDIR損/test/ruby/test_refinement.rb:786:in `test_prepend_after_refine_wb_miss'

```

Please consider bumping the timeout and/or excluding the test?

Please also backport this to 2.3. Thanks!



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next