[#70252] Re: [ruby-cvs:58640] nobu:r51492 (trunk): node.c: NODE_ALLOCA for ALLOCV — Eric Wong <normalperson@...>
Besides possible backwards compatibility, can we drop volatile
3 messages
2015/08/05
[#70257] [Ruby trunk - Feature #11420] [Open] Introduce ID key table into MRI — ko1@...
Issue #11420 has been reported by Koichi Sasada.
11 messages
2015/08/06
[#70337] Re: [Ruby trunk - Feature #11420] [Open] Introduce ID key table into MRI
— Eric Wong <normalperson@...>
2015/08/11
Nice. Thank you guys for looking into this.
[#70349] Re: [Ruby trunk - Feature #11420] [Open] Introduce ID key table into MRI
— Eric Wong <normalperson@...>
2015/08/12
Btw, did you consider using flexible array to avoid extra malloc
[#70355] Re: [Ruby trunk - Feature #11420] [Open] Introduce ID key table into MRI
— Юрий Соколов <funny.falcon@...>
2015/08/12
I thought to suggest to embed hash_id_table directly into places when it is
[#70356] Re: [Ruby trunk - Feature #11420] [Open] Introduce ID key table into MRI
— SASADA Koichi <ko1@...>
2015/08/12
On 2015/08/13 4:29, Юрий Соколов wrote:
[#70358] Re: [Ruby trunk - Feature #11420] [Open] Introduce ID key table into MRI
— Eric Wong <normalperson@...>
2015/08/12
SASADA Koichi <ko1@atdot.net> wrote:
[#70509] [Ruby trunk - Misc #11276] [RFC] compile.c: convert to use ccan/list — ko1@...
Issue #11276 has been updated by Koichi Sasada.
3 messages
2015/08/21
[#70639] the undefined behavior of an iterator if it is modified inside of the block to which it yields — Daniel Doubrovkine <dblock@...>
(this is my first time e-mailing list list, so apologies for any misstep :)
4 messages
2015/08/31
[ruby-core:70415] [Ruby trunk - Bug #11058] [PATCH] Net::HTTPResponse#read_body raises TypeError when receiving empty gzipped response body
From:
usa@...
Date:
2015-08-17 08:40:59 UTC
List:
ruby-core #70415
Issue #11058 has been updated by Usaku NAKAMURA.
Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: DONE to 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE
ruby_2_1 r51609 merged revision(s) 46681,51464,51465.
note: r46681 was not backported into `ruby_2_1`, so it is also backported with these changes.
----------------------------------------
Bug #11058: [PATCH] Net::HTTPResponse#read_body raises TypeError when receiving empty gzipped response body
https://bugs.ruby-lang.org/issues/11058#change-53823
* Author: Kazuki Tsujimoto
* Status: Closed
* Priority: Normal
* Assignee: Yui NARUSE
* ruby -v: ruby 2.3.0dev (2015-04-11 master 50228) [x86_64-linux]
* Backport: 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE
----------------------------------------
Following code raises TypeError.
~~~ruby
require 'net/http'
def dummy_io(str)
str = str.gsub(/\n/, "\r\n")
Net::BufferedIO.new(StringIO.new(str))
end
io = dummy_io(<<EOS)
HTTP/1.1 200 OK
Connection: close
Content-Encoding: deflate
Content-Length: 0
EOS
res = Net::HTTPResponse.read_new(io)
res.decode_content = true
res.reading_body io, true do
res.read_body
end
~~~
There are two problems.
(1) In Net::HTTPResponse#inflater, `e` may be nil and causes TypeError if `inflate_body_io.finish` failed.
~~~ruby
begin
yield inflate_body_io
ensure
e = $!
begin
inflate_body_io.finish
rescue
raise e
end
end
~~~
(2) Zlib::ZStream#finish raises Zlib::BufError when inflating an empty string, so we should avoid calling #finish in such case.
~~~ruby
require 'zlib'
inflate = Zlib::Inflate.new
inflate.inflate('')
inflate.finish #=> Zlib::BufError: buffer error
~~~
---Files--------------------------------
0001-lib-net-http-response.rb-Net-HTTPResponse-inflater-f.patch (882 Bytes)
0002-lib-net-http-response.rb-Net-HTTPResponse-Inflater.patch (2.78 KB)
--
https://bugs.ruby-lang.org/