From: naruse@...
Date: 2015-02-20T08:52:20+00:00
Subject: [ruby-core:68197] [Ruby trunk - Bug #10831] Variable keyword arguments shouldn't create immortal symbols

Issue #10831 has been updated by Yui NARUSE.

Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

ruby_2_2 r49666 merged revision(s) 49517.

----------------------------------------
Bug #10831: Variable keyword arguments shouldn't create immortal symbols
https://bugs.ruby-lang.org/issues/10831#change-51567

* Author: Marc-Andre Lafortune
* Status: Closed
* Priority: Normal
* Assignee: Nobuyoshi Nakada
* ruby -v: r49512
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE
----------------------------------------
Calling a method with keyword arguments will, sometimes, create immortal symbols.

The following tests should not fail:

    def test_kwarg_symbol_leak_no_rest
      foo = -> (arg: 42) {}
      assert_no_immortal_symbol_created("kwarg no rest") do |name|
        assert_raise(ArgumentError) { foo.call(name.to_sym => 42) }
      end
    end

    def test_kwarg_symbol_leak_with_rest
      foo = -> (arg: 2, **options) {}
      assert_no_immortal_symbol_created("kwarg with rest") do |name|
        foo.call(name.to_sym => 42)
      end
    end

    def test_kwarg_symbol_leak_just_rest
      foo = -> (**options) {}
      assert_no_immortal_symbol_created("kwarg just rest") do |name|
        foo.call(name.to_sym => 42)
      end
    end

Note: the last one succeeds (because the hash is simply cloned internally), and is there for completeness.



-- 
https://bugs.ruby-lang.org/