From: "eightbitraptor (Matthew Valentine-House) via ruby-core" <ruby-core@...>
Date: 2023-02-16T14:50:03+00:00
Subject: [ruby-core:112456] [Ruby master Bug#19442] Remove USE_RINCGC flag

Issue #19442 has been updated by eightbitraptor (Matthew Valentine-House).





@nobu I see you've just fixed it in [this commit](https://github.com/ruby/ruby/commit/21543ac86ce0b730c1381588d7dc9eb0e32277c7) ����



Thanks! 



I'd still like to see it removed, but I'll update the ticked description to be more reflective of the current status.



----------------------------------------

Bug #19442: Remove USE_RINCGC flag

https://bugs.ruby-lang.org/issues/19442#change-101900



* Author: eightbitraptor (Matthew Valentine-House)

* Status: Open

* Priority: Normal

* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN

----------------------------------------

[GitHub PR #7317](https://github.com/ruby/ruby/pull/7313)



Ruby doesn't compile when USE_RINCGC is disabled. It's also not being tested in CI. As @nobu has pointed out in comments on the PR, fixing it is simple.



I think there are 2 approaches we could take:



1. Remove `USE_RINCGC` entirely and always run with incremental GC enabled. We have a precedent for this: `USE_RGENGC=0` was removed [in this commit](https://github.com/ruby/ruby/commit/62c2b8c74e47652fc5bbaf6150f4acd092dfd72b) almost 3 years ago. `USE_RINCGC=0` is in a similar state. It has been broken for almost a year (since [this commit](https://github.com/ruby/ruby/commit/dde164e968e382d50b07ad4559468885cbff33ef)), and [disabled in CI for more than 2 years](https://github.com/ruby/ruby/commit/46d3ea2c2569e2e5a9ee3e7e206f07f0f8b693f5).



2. We could fix `USE_RINCGC`. If we do this we should re-enable the CI task so that we continue to keep it working in the future.



I am very much in favour of option 1, because I don't think this flag is being actively used, and removing it will simplify the code and reduce the cognitive overhead of working with the GC. However I am happy to defer to the team here. 











-- 

https://bugs.ruby-lang.org/

 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/