[ruby-core:112851] [Ruby master Feature#19437] Add marking and sweeping time to GC.stat

Issue #19437 has been updated by peterzhu2118 (Peter Zhu).


> Is compaction time classified as marking_time or sweeping_time?

It will be part of sweeping_time. I think it's not very accurate to have a compacting_time because we do sweeping during compaction, so I chose to put compaction time in sweeping_time. It might make sense to have compacting_time in the future, but since it's disabled by default and I'm not aware of any production services using auto-compaction in production (we only run `GC.compact` before forking here at Shopify), so we don't need this data right now.

> does the current patch (already merged) split it?

I refactored the code so that the marking and sweeping phases are separated (in [d7c1ca4](https://github.com/ruby/ruby/commit/d7c1ca48bf7754a23bfe1559422736029b4787a0).

----------------------------------------
Feature #19437: Add marking and sweeping time to GC.stat
https://bugs.ruby-lang.org/issues/19437#change-102363

* Author: peterzhu2118 (Peter Zhu)
* Status: Closed
* Priority: Normal
----------------------------------------
Pull Request: https://github.com/ruby/ruby/pull/7304

There is a `time` key in GC.stat that gives us the total time spent in GC. However, we don't know what proportion of the time is spent between marking and sweeping. This makes it difficult to tune the GC as we're not sure where to focus our efforts on.

This PR adds keys `marking_time` and `sweeping_time` to GC.stat for the time spent marking and sweeping, in milliseconds.





-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/