[ruby-core:105577] [Ruby master Bug#18232] Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
From:
"tenderlovemaking (Aaron Patterson)" <noreply@...>
Date:
2021-10-06 18:47:30 UTC
List:
ruby-core #105577
Issue #18232 has been updated by tenderlovemaking (Aaron Patterson).
It looks like the [outer variables list](https://github.com/ruby/ruby/blob/e4d85d3a2d0c7d4a1abf981fb1ba557e21cad968/vm.c#L1124) is being lost when we dump the iseq to binary. AFAICT, that list is only created at compile time. I'll try to make a patch that reconstructs the list on iseq load as well.
----------------------------------------
Bug #18232: Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
https://bugs.ruby-lang.org/issues/18232#change-94035
* Author: byroot (Jean Boussier)
* Status: Open
* Priority: Normal
* ruby -v: ruby 3.0.2p107, ruby 3.1.0dev
* Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
This was first reported as a Bootsnap bug: https://github.com/Shopify/bootsnap/issues/376
But I reduced it to:
```ruby
source = <<~RUBY
x = :foo
pr = Proc.new { p x }
Ractor.make_shareable(pr)
pr.call
RUBY
RubyVM::InstructionSequence.compile(source).eval # :foo
RubyVM::InstructionSequence.load_from_binary(RubyVM::InstructionSequence.compile(source).to_binary).eval # false
```
The bug is present on both 3.0.2 and 3.1.0-dev. I have no idea what might cause this.
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>