From: "Eregon (Benoit Daloze)" Date: 2021-10-04T12:38:58+00:00 Subject: [ruby-core:105540] [Ruby master Feature#18231] `RubyVM.keep_script_lines` Issue #18231 has been updated by Eregon (Benoit Daloze). ko1 (Koichi Sasada) wrote in #note-13: > Do you talking about `toSource` method in JS? Yeah it's JS Function's `toSource`, but since it's an object it would also provide more information like line & column info. > for debugger/error_highlight we need source code other than methods so Method is not enough. For what else do you need to get the source? `Ruby::AbstractSyntaxTree::Node`? How do you get the `Ruby::AbstractSyntaxTree::Node` if it's eval'd code? Is it really needed on `RubyVM::InstructionSequence`? That's probably the worst for portability as some Ruby implementations don't have bytecode or don't want to expose it. ---------------------------------------- Feature #18231: `RubyVM.keep_script_lines` https://bugs.ruby-lang.org/issues/18231#change-93996 * Author: ko1 (Koichi Sasada) * Status: Open * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Target version: 3.1 ---------------------------------------- This ticket proposes the method `RubyVM.keep_script_lines` to manage the flag to keep the source code. Now, `SCRIPT_LINES__ = {}` constant is defined, the hash will stores the compiled script with a path name (`{path => src}`). However, `eval` source code doesn't stores in it (maybe because it can be bigger and bigger). ## Proposal This proposal to add script lines to the ISeq and AST. ```ruby RubyVM::keep_script_lines = true eval("def foo = nil\ndef bar = nil") pp RubyVM::InstructionSequence.of(method(:foo)).script_lines #=> ["def foo = nil\n", "def bar = nil"] ``` In this case, methods `foo` and `bar` are defined by `eval()` and ISeq of `foo` can returns script lines (all script for `eval`). `ISeq#script_lines` returns compiled script lines. When `ISeq` is GCed, then the source code will be also free'ed. ## Discussion * This feature will be used by debugger (to show the source code) or REPL support (irb and so on) with `error_highlight`. * Of course memory usage will be increased. * We can introduce new status `only_eval` in future which will help REPL systems. * We can implement `ISeq#source` method like `AST#source` method (similar to `toSource` in JavaScript), but this ticket doesn't contain it. ## Implementation https://github.com/ruby/ruby/pull/4913 For the Ractor support script lines object should be immutable (not implemented yet). -- https://bugs.ruby-lang.org/ Unsubscribe: