From: ruby-core@...
Date: 2019-04-12T22:42:11+00:00
Subject: [ruby-core:92266] [Ruby trunk Bug#15515] OpenStruct raising NoMethodError instead of ArgumentError

Issue #15515 has been updated by marcandre (Marc-Andre Lafortune).

Assignee set to marcandre (Marc-Andre Lafortune)

Sorry I missed this.

I'm positive on this patch and will commit it shortly unless there's any objection.

----------------------------------------
Bug #15515: OpenStruct raising NoMethodError instead of ArgumentError
https://bugs.ruby-lang.org/issues/15515#change-77599

* Author: lugray (Lisa Ugray)
* Status: Open
* Priority: Normal
* Assignee: marcandre (Marc-Andre Lafortune)
* Target version: 
* ruby -v: ruby 2.7.0dev (2019-01-07 trunk 66747) [x86_64-darwin18]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
When an `OpenStruct` has some attribute `foo`, calling the `foo` method with an argument gives a no method error:
```ruby
foo = OpenStruct.new(bar: 'baz')
foo.bar(0) # => NoMethodError (undefined method `bar' for #<OpenStruct bar="baz">)
```

This is confusing, since `foo.respond_to?(:bar) # => true`. I would expect:
```ruby
foo = OpenStruct.new(bar: 'baz')
foo.bar(0) # => ArgumentError (wrong number of arguments (given 1, expected 0))
```

The included fixes this, and adjusts the arity `ArgumentError` for the setter to be in line with the default arity messaging too.

---Files--------------------------------
0001-ostruct.rb-refine-arity-failure-message.patch (1.26 KB)
0001-ostruct.rb-refine-arity-failure-message.patch (1.96 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>