From: ko1@... Date: 2018-11-06T06:38:34+00:00 Subject: [ruby-core:89720] [Ruby trunk Bug#15270][Closed] [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary Issue #15270 has been updated by ko1 (Koichi Sasada). Status changed from Open to Closed Assignee set to ko1 (Koichi Sasada) Thank you! You are completely right. applied at r65567 (I forget to add ticket reference on commit log). ---------------------------------------- Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary https://bugs.ruby-lang.org/issues/15270#change-74764 * Author: alanwu (Alan Wu) * Status: Closed * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Target version: * ruby -v: * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- Hello. This is a patch for Bug #14702, which I don't think is fully addressed. The tests in the patch should fail on both trunk and ruby_2_5. ~~~ Fix TracePoint for nested iseq loaded from binary [Bug #14702] When loading iseq from binary while a TracePoint is on, we need to recompile instructions to their "trace_" variant. Before this commit we only recompiled instructions in the top level iseq, which meant that TracePoint was malfunctioning for code inside module/class/method definitions. * compile.c: Move rb_iseq_init_trace to rb_ibf_load_iseq_complete. It is called on all iseqs during loading. * test_iseq.rb: Test that tracepoints fire within children iseq when using load_from_binary. ~~~ ---Files-------------------------------- 0001-Fix-TracePoint-for-nested-iseq-loaded-from-binary.patch (4.21 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: