[ruby-core:77551] [Ruby trunk Bug#12828][Closed] Check whether macro RUBY is okay for protecting ruby-specific onigumo extensions

From: nobu@...
Date: 2016-10-11 06:59:13 UTC
List: ruby-core #77551
Issue #12828 has been updated by Nobuyoshi Nakada.

Status changed from Open to Closed

It should be OK.

----------------------------------------
Bug #12828: Check whether macro RUBY is okay for protecting ruby-specific onigumo extensions
https://bugs.ruby-lang.org/issues/12828#change-60817

* Author: Martin D端rst
* Status: Closed
* Priority: Normal
* Assignee: Nobuyoshi Nakada
* ruby -v: 
* Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
----------------------------------------
In issue #12386, I removed the ONIG_CASE_MAPPING macro because we thought that there was no need to keep the Ruby version of Onigumo in sync with the original version (see https://bugs.ruby-lang.org/issues/12386#note-1).

However, there's now a plan to integrate the Ruby-side changes into the original Onigumo version (see https://github.com/k-takata/Onigmo/pull/58). The proposal is to surround the Ruby-specific changes by #ifdef RUBY (see https://github.com/k-takata/Onigmo/issues/66).

We should check whether we are okay with #ifdef RUBY, or we would prefer something else.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next