From: nobu@... Date: 2016-10-11T15:39:50+00:00 Subject: [ruby-core:77584] [Ruby trunk Bug#10222] require_relative and require should be compatible with each other when symlinks are used Issue #10222 has been updated by Nobuyoshi Nakada. Shyouhei Urabe wrote: > In order to do so a meeting attendee suggested to push both symlink-resolved and unresolved paths at once to `$LOADED_FEATURES` on the first call. I think this explanation differs from that we discussed accurately. IIRC, it should be `vm->expanded_load_path`, not `$LOADED_FEATURES`. `$LOADED_FEATURES` won't be doubled, but will have realpaths only. ---------------------------------------- Bug #10222: require_relative and require should be compatible with each other when symlinks are used https://bugs.ruby-lang.org/issues/10222#change-60855 * Author: Rodrigo Rosenfeld Rosas * Status: Open * Priority: Normal * Assignee: * ruby -v: 2.3.1, 2.1.2p95 * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN ---------------------------------------- Not sure if this should be considered a bug or a feature request since I don't know whether the current behavior is intended or not. Recently I got a report for my gem rails-web-console related to require_relative causing trouble with symlinked dirs: https://github.com/rosenfeld/active_record_migrations/issues/6 Dmitry was able to replicate the issue using vanilla Ruby: ~~~ mkdir a ln -s a b echo "require_relative 'b'" > a/a.rb echo "p 'b loaded'" > a/b.rb echo "$: << File.expand_path('../b', __FILE__); require 'a'; require 'b'" > c.rb ruby c.rb ~~~ Notice how "b loaded" is printed twice but if you replace require_relative with require it's just loaded once. Shouldn't Ruby always expand the loaded files before appending them to the $LOADED_FEATURES and avoid this kind of error? I don't think require_relative should behave differently than a regular require in such cases. Any thoughts? -- https://bugs.ruby-lang.org/ Unsubscribe: