[ruby-core:117376] [Ruby master Feature#20384] RubyVM::InstructionSequence.{new,compile} use --parser option
From:
"kddnewton (Kevin Newton) via ruby-core" <ruby-core@...>
Date:
2024-03-29 15:18:33 UTC
List:
ruby-core #117376
Issue #20384 has been updated by kddnewton (Kevin Newton).
I've opened a PR here https://github.com/ruby/ruby/pull/10406. I'm assuming no one has an objection based on the silence, so I'll merge once CI passes.
----------------------------------------
Feature #20384: RubyVM::InstructionSequence.{new,compile} use --parser option
https://bugs.ruby-lang.org/issues/20384#change-107535
* Author: kddnewton (Kevin Newton)
* Status: Open
----------------------------------------
Right now we have `RubyVM::InstructionSequence.compile` and `RubyVM::InstructionSequence.compile_prism`. We introduced this API in order to properly test the integration, even when running with `--parser=parse.y`.
I'm running into issues, however, when tests are comparing between `eval` and `RubyVM::InstructionSequence.new`. The latter always uses `parse.y`, even if `--parser=prism` is passed on the command line. I would like to change that so that `RubyVM::InstructionSequence.{new,compile}` respects the `--parser` option so that it's consistent.
Would this change be okay? It would only impact processes with `--parser=prism`, so I don't imagine there's any kind of risk here.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/