From: "kddnewton (Kevin Newton) via ruby-core" <ruby-core@...>
Date: 2025-03-13T13:50:03+00:00
Subject: [ruby-core:121342] [Ruby master Bug#20340] Ractor comments not applying to constant targets
Issue #20340 has been updated by kddnewton (Kevin Newton).
Status changed from Open to Closed
Based on https://bugs.ruby-lang.org/issues/21016#note-4, I think this is the expected behavior.
----------------------------------------
Bug #20340: Ractor comments not applying to constant targets
https://bugs.ruby-lang.org/issues/20340#change-112314
* Author: kddnewton (Kevin Newton)
* Status: Closed
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
In this example:
```ruby
C, = { foo: bar }
```
You get:
```
== disasm: #<ISeq:<main>@test.rb:1 (1,0)-(1,17)>
0000 putobject :foo ( 1)[Li]
0002 putself
0003 opt_send_without_block <calldata!mid:bar, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0005 newhash 2
0007 dup
0008 expandarray 1, 0
0011 putspecialobject 3
0013 setconstant :C
0015 leave
```
But there's no difference from:
```ruby
# shareable_constant_value: literal
C, = { foo: bar }
```
I would have expected:
```
== disasm: #<ISeq:<main>@test.rb:1 (1,0)-(2,16)>
0000 putobject RubyVM::FrozenCore ( 2)[Li]
0002 putobject :foo
0004 putobject RubyVM::FrozenCore
0006 putself
0007 opt_send_without_block <calldata!mid:bar, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0009 putobject "C"
0011 opt_send_without_block <calldata!mid:ensure_shareable, argc:2, ARGS_SIMPLE>
0013 newhash 2
0015 opt_send_without_block <calldata!mid:make_shareable, argc:1, ARGS_SIMPLE>
0017 dup
0018 expandarray 1, 0
0021 putspecialobject 3
0023 setconstant :C
0025 leave
```
Is this omission intentional? For context, I'm building this in prism and I need to know if I should explicitly disable this behavior.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/