From: "smcgivern (Sean McGivern)" Date: 2022-11-04T11:20:58+00:00 Subject: [ruby-core:110606] [Ruby master Bug#19101] madvise(free) was broken in 3.1? Issue #19101 has been updated by smcgivern (Sean McGivern). ioquatix (Samuel Williams) wrote: > https://github.com/ruby/ruby/commit/77f3319071e600a2aafaa9863b892dfd3c1da343#r88774579 > > We need to investigate why this was done, how to fix it, and how to prevent regressions in the future. I don't think it's appropriate for Ruby itself to do this particular test, but could the Falcon project add benchmarks like https://bugs.ruby-lang.org/issues/15997#note-19 to CI? I guess if https://github.com/socketry/falcon-benchmark ran against different Ruby versions, you could also plot that. Beyond that, the test with `strace` (using `dtruss` where applicable) in https://github.com/ruby/ruby/commit/77f3319071e600a2aafaa9863b892dfd3c1da343#r88774579 is fairly trivial but would involve shelling out, so I'm not sure if that's the kind of thing that typically happens in the Ruby core project either. ---------------------------------------- Bug #19101: madvise(free) was broken in 3.1? https://bugs.ruby-lang.org/issues/19101#change-99938 * Author: ioquatix (Samuel Williams) * Status: Closed * Priority: Normal * Assignee: ioquatix (Samuel Williams) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- https://github.com/ruby/ruby/commit/77f3319071e600a2aafaa9863b892dfd3c1da343#r88774579 We need to investigate why this was done, how to fix it, and how to prevent regressions in the future. -- https://bugs.ruby-lang.org/ Unsubscribe: