[#69084] [Ruby trunk - Feature #11124] [Open] [PATCH] lib/*: use monotonic clock for timeouts — normalperson@...
Issue #11124 has been reported by Eric Wong.
5 messages
2015/05/06
[#69138] [Ruby trunk - Feature #11136] [PATCH] webrick: avoid fcntl module — nobu@...
Issue #11136 has been updated by Nobuyoshi Nakada.
3 messages
2015/05/12
[#69160] [Ruby trunk - Feature #11146] [PATCH] variable.c: initialize generic_iv_tbl at start — nobu@...
Issue #11146 has been updated by Nobuyoshi Nakada.
4 messages
2015/05/13
[#69175] Re: [Ruby trunk - Feature #11146] [PATCH] variable.c: initialize generic_iv_tbl at start
— Eric Wong <normalperson@...>
2015/05/13
nobu@ruby-lang.org wrote:
[ruby-core:69104] [Ruby trunk - Bug #11121] [Feedback] openssl ext does not handle EWOULDBLOCK
From:
shibata.hiroshi@...
Date:
2015-05-08 06:43:29 UTC
List:
ruby-core #69104
Issue #11121 has been updated by Hiroshi SHIBATA.
Status changed from Open to Feedback
Is there this issue on Ruby 2.1 or 2.2? Ruby 1.9.3 is EOL.
----------------------------------------
Bug #11121: openssl ext does not handle EWOULDBLOCK
https://bugs.ruby-lang.org/issues/11121#change-52348
* Author: Pep Turr坦 Mauri
* Status: Feedback
* Priority: Normal
* Assignee:
* ruby -v: ruby 1.9.3p551 (2014-11-13) [i386-mingw32]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
On Windows, non-blocking IO on sockets seems to return EWOULDBLOCK instead of EAGAIN. The openssl ruby library only handles EAGAIN, which results in EWOULDBLOCK being raised to the caller.
This was noticed while using httpclient to send a POST request to an https server via an http proxy on a Windows system:
~~~
A non-blocking socket operation could not be completed immediately. (Errno::EWOULDBLOCK)
C:/Ruby193/lib/ruby/1.9.1/openssl/buffering.rb:53:in `sysread'
C:/Ruby193/lib/ruby/1.9.1/openssl/buffering.rb:53:in `sysread'
C:/Ruby193/lib/ruby/1.9.1/openssl/buffering.rb:53:in `fill_rbuff'
C:/Ruby193/lib/ruby/1.9.1/openssl/buffering.rb:200:in `gets'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:356:in `gets'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:876:in `block in parse_header'
C:/Ruby193/lib/ruby/1.9.1/timeout.rb:55:in `timeout'
C:/Ruby193/lib/ruby/1.9.1/timeout.rb:100:in `timeout'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:872:in `parse_header'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:833:in `connect_ssl_proxy'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:753:in `block in connect'
C:/Ruby193/lib/ruby/1.9.1/timeout.rb:55:in `timeout'
C:/Ruby193/lib/ruby/1.9.1/timeout.rb:100:in `timeout'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:746:in `connect'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:612:in `query'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:164:in `query'
...
~~~
We could only reproduce it in this environment so far (old version, invoking this particular call, over a proxy) but I believe the same problem can appear at any time with current versions.
An example from current trunk (ext/openssl/lib/openssl/buffering.rb):
~~~
def fill_rbuff
begin
@rbuffer << self.sysread(BLOCK_SIZE)
rescue Errno::EAGAIN
retry
rescue EOFError
@eof = true
end
end
~~~
there are multiple references in that file, e.g.
https://github.com/ruby/ruby/blob/trunk/ext/openssl/lib/openssl/buffering.rb#L62
https://github.com/ruby/ruby/blob/trunk/ext/openssl/lib/openssl/buffering.rb#L327
--
https://bugs.ruby-lang.org/