[#102652] [Ruby master Bug#17664] Behavior of sockets changed in Ruby 3.0 to non-blocking — ciconia@...
Issue #17664 has been reported by ciconia (Sharon Rosner).
23 messages
2021/02/28
[ruby-core:102375] [Ruby master Bug#17552] [PATCH] Fix a NULL pointer crash in ObjectSpace.dump_all
From:
naruse@...
Date:
2021-02-02 06:44:47 UTC
List:
ruby-core #102375
Issue #17552 has been updated by naruse (Yui NARUSE).
Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: DONE
ruby_3_0 06da90a146346d6968a8716a9035ede7104c0f97 merged revision(s) 6ca3d1af3302f722aed530764d07c1cc83e95ecf.
----------------------------------------
Bug #17552: [PATCH] Fix a NULL pointer crash in ObjectSpace.dump_all
https://bugs.ruby-lang.org/issues/17552#change-90236
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* ruby -v: ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-darwin19]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: DONE
----------------------------------------
Patch: https://github.com/ruby/ruby/pull/4078
I wasn't able to reproduce the issue in isolation just yet, but I confirmed the patch fixes the issue for us.
What seem to happen in that some objects have an `allocation_info`, but `allocation_info->path == NULL`.
What is weird is that in 2.7.2, [there was no NULL check for `->path`, it was directly passed to `vfprintf`](https://github.com/ruby/ruby/blob/5445e0435260b449decf2ac16f9d09bae3cafe72/ext/objspace/objspace_dump.c#L322-L323), which from what I understand would have generated `"path": (null)`, which is invalid JSON.
So I suspect `allocation_info { path = NULL }` wasn't possible on 2.7.2?
Either way I'd like to write a test case for this, but I'm still unable to find a way to create an object with a NULL `path`.
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>