From: Chris Thomas <chris@...>
Date: 2003-12-03T09:43:47+09:00
Subject: Re: rdoc included in standard distribution?


On Dec 1, 2003, at 6:48 AM, Dave Thomas wrote:

>    require 'rdoc/rdoc'
>
>    rdoc = RDoc::RDoc.new
>    rdoc.document(args)
>
> And you can now do this in the CVS version of Ruby.

Super cool. But I ran into one thing right away:

% rdoc --help
/usr/local/lib/ruby/1.8/rdoc/diagram.rb:7:in `require': No such file to 
load -- dot/dot (LoadError)
         from /usr/local/lib/ruby/1.8/rdoc/diagram.rb:7
         from /usr/local/lib/ruby/1.8/rdoc/rdoc.rb:22:in `require'
         from /usr/local/lib/ruby/1.8/rdoc/rdoc.rb:22
         from /usr/local/bin/rdoc:59:in `require'
         from /usr/local/bin/rdoc:59

Could that dependency be conditionalized, as in the following patch?

Index: lib/rdoc/rdoc.rb
===================================================================
RCS file: /src/ruby/lib/rdoc/rdoc.rb,v
retrieving revision 1.1
diff -u -c -3 -r1.1 rdoc.rb
cvs server: conflicting specifications of output style
*** lib/rdoc/rdoc.rb    1 Dec 2003 07:12:48 -0000       1.1
--- lib/rdoc/rdoc.rb    3 Dec 2003 00:32:52 -0000
***************
*** 19,26 ****
   require 'rdoc/parsers/parse_simple.rb'
   require 'rdoc/options'

- require 'rdoc/diagram'
-
   require 'find'
   require 'ftools'

--- 19,24 ----
***************
*** 206,212 ****
           end

           begin
!           Diagram.new(file_info, options).draw if options.diagram
             gen.generate(file_info)
           ensure
             Dir.chdir(pwd)
--- 204,213 ----
           end

           begin
!           if options.diagram
!             require 'rdoc/diagram'
!             Diagram.new(file_info, options).draw
!           end
             gen.generate(file_info)
           ensure
             Dir.chdir(pwd)

Thanks,
Chris (no relation :)