From: nobu.nokada@...
Date: 2003-05-16T09:56:56+09:00
Subject: Re: PTY: still problems (+patch)

Hi,

At Fri, 16 May 2003 05:55:13 +0900,
Laurent Sansonetti wrote:
> After some pty.c debug, I noticed that pty_finalize_syswait() was
> called *before* pty_syswait(), thus the thread was killed before it
> could call rb_waitpid().

I noticed a bit different problem on Linux, EIO occurs.

> The following patch fixes this issue, by 'joining' the thread instead of killing it:

And your patch also fixes it.

> -    rb_thread_kill(info->thread);
> +    rb_funcall(info->thread, rb_intern("join"), 0);

Here, it might be better to use "value".

> BTW, I saw that rb_thread_join() is private.  Perhaps it should be
> exported, in order to use its 'limit' parameter here.  

I agree to export it (and rb_thread_value maybe), but could you
explain why 'limit' is needed here?

-- 
Nobu Nakada