From: "Matthew, Graeme" Date: 2002-09-20T09:42:42+09:00 Subject: Criticise me Hi all, busy working on my classes and would appreciate any consturctive or negative advice on wether I am doing the "correct" thing here, or better if there are better ways, before I start getting entrenched in bad habits some experienced persons advice may save me a lot of pain :-) feel free to say what you want , it wont offend require "C:/dev/cgi-bin/DbHighlander.rb" class Project SQL_PROJECT = "SELECT prj_id, prj_name, prj_description, prj_commenced, prj_completed, prj_status,prj_acc_id FROM project " def initialize(id=nil) @data = nil if defined? id db = DbHighlander.Connection qry = db.prepare(SQL_PROJECT + " WHERE prj_id = #{project_id} ") qry.execute @data = qry.fetch_hash qry.finish end end #Class Attributes def Code return @data['prj_id'] end def Name(name) if defined? name then @data['prj_name'] = name end return @data['prj_name] end def Description(description) if defined? name then @data['prj_description'] = description end return @data['prj_description] end end Graeme Matthew Analyst Programmer Mercer Investment Consulting Level 29, 101 Collins Street, Melbourne, VIC, 3001, Australia Tel - 61 3 9245 5352 Fax - 61 3 9245 5330 visit http://www.merceric.com __ ********************************************** This e-mail and any attachments may be confidential or legally privileged. If you received this message in error or are not the intended recipient, you should destroy the e-mail message and any attachments or copies, and you are prohibited from retaining, distributing, disclosing or using any information contained herein. Please inform us of the erroneous delivery by return e-mail. Thank you for your cooperation. ********************************************** ec03/04