From: Joel Pearson <lists@...>
Date: 2013-03-14T21:50:09+09:00
Subject: Re: RubyExcel class. Useful?

Martin DeMello wrote in post #1101514:
> Took a quick look at the code; this bit looks wrong:
>
> def delete(ref)
> ...
> @sheets.delete_at( ref + 1 )
>
> I think it should be (ref - 1). Which brings me to my main point, that
> 1-indexing is tricky and should be bolstered by a lot of tests in case
> you inadvertently slip up. Also @sheets.delete_at changes the array
> whereas @sheets.reject does not; it should be reject! for consistency.
> (Again, tests would have caught this.)
>
> martin

When I "delete" a sheet, do I just need to stop referring to it as an 
object? As I understand it; once it's removed from "@sheets", it should 
be garbage collected.

-- 
Posted via http://www.ruby-forum.com/.